Review main Merged

51208[TASK] Replace ExtDirect State for module menu with jQuery

Benni Mack CR +2 V +2 Easy +21 −22 updated 01/09/17, 09:05

Commit message

The obsolete State Provider for storing and retrieving the information 
if the backend module menu should be collapsed or not
should not use ExtDirect but instead us the native Storage functionality
already in place for TYPO3.

The namespace (BackendComponents.States.typo3-module-menu) is
kept for now (see BackendController.php for details on ExtDirect), but could
easily be modified.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Georg Ringer +1
  • Verified V +2
    • Wouter Wolters +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 811

  1. Benni Mack uploaded patch set 1 01/09/17, 06:08

  2. TYPO3com voted on patch set 1 V +1 01/09/17, 06:12 Completed build in 04m 00s on Mon, 9 Jan, 07:12 AM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6306

  3. Benni Mack uploaded patch set 2 01/09/17, 06:14

  4. TYPO3com voted on patch set 2 V +1 01/09/17, 06:18 Completed build in 04m 06s on Mon, 9 Jan, 07:18 AM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6307

  5. Wouter Wolters voted on patch set 2 CR +1 01/09/17, 07:33

  6. Georg Ringer updated the commit message in patch set 3 01/09/17, 07:54

  7. Georg Ringer voted on patch set 3 CR +1 V +1 01/09/17, 07:55

  8. Wouter Wolters voted on patch set 3 CR +1 01/09/17, 07:56

  9. TYPO3com voted on patch set 3 V +1 01/09/17, 07:58 Completed build in 03m 47s on Mon, 9 Jan, 08:58 AM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6312

  10. Wouter Wolters voted on patch set 3 CR +2 V +2 01/09/17, 09:05

  11. Gerrit merged patch set 3 01/09/17, 09:05