Review main Merged

51209[TASK] Simplify module menu loading functionality

Benni Mack CR +2 V +2 Easy +1 −11 updated 01/09/17, 12:30

Commit message

As there is no relative path functionality but only absolute
URLs (without the domain name but just prepended) the functionality
of stripping the siteUrl is removed, thus allowing to remove the hardcoded
"/typo3/" name in the URL and the siteUrl configuration option as well.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Mona Muzaffar +1
  • Verified V +2
    • Wouter Wolters +2
    • Mona Muzaffar +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 78

  1. Benni Mack uploaded patch set 1 01/09/17, 06:24

  2. TYPO3com voted on patch set 1 V +1 01/09/17, 06:28 Completed build in 03m 32s on Mon, 9 Jan, 07:28 AM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6308

  3. Wouter Wolters voted on patch set 1 CR +1 01/09/17, 07:35

  4. Wouter Wolters commented on patch set 1 V +1 01/09/17, 09:10

    Checked TER for configuration.siteUrl. Only 2 extensions found that are really old.
  5. Mona Muzaffar voted on patch set 1 CR +1 01/09/17, 12:11

  6. Mona Muzaffar voted on patch set 1 V +1 01/09/17, 12:29

  7. Wouter Wolters voted on patch set 1 CR +2 V +2 01/09/17, 12:29

  8. Gerrit merged patch set 1 01/09/17, 12:30