Review main Merged

51212[TASK] Use $ instead of TYPO3.jQuery

Benni Mack CR +2 V +2 Normal +98 −81 updated 01/10/17, 12:32

Commit message

In TYPO3 6.0 we introduced TYPO3.jQuery as a possibility to have jQuery
run side-by-side with prototype.js in a no-conflict mode.

Since TYPO3 7.5, prototype.js was removed, and $ can be used.

PageRenderer now sets TYPO3.jQuery AND $ as shorthand-functionality
and all places in the TYPO3 Core are replaced with the common $
functionality, so TYPO3.jQuery should be avoided.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2
    • Georg Ringer +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 18

Review log 1216

  1. Benni Mack uploaded patch set 1 01/09/17, 09:15

  2. TYPO3com voted on patch set 1 V +1 01/09/17, 09:19 Completed build in 04m 20s on Mon, 9 Jan, 10:19 AM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6316

  3. Wouter Wolters commented on patch set 1 01/09/17, 09:23

    ReplaceFile.html:22

    use spaces
  4. Benni Mack commented on patch set 2 01/09/17, 12:23

    Published edit on patch set 1.
  5. TYPO3com voted on patch set 2 V +1 01/09/17, 12:27 Completed build in 04m 07s on Mon, 9 Jan, 01:27 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6327

  6. Benni Mack updated the commit message in patch set 3 01/09/17, 15:44

  7. TYPO3com voted on patch set 3 V +1 01/09/17, 15:49 Completed build in 04m 42s on Mon, 9 Jan, 04:49 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6339

  8. Susi Moog commented on patch set 3 CR +1 V +1 01/09/17, 16:25

    maybe add an important rst because of the pagerenderer change.
  9. Benni Mack uploaded patch set 4 01/10/17, 10:09

  10. TYPO3com voted on patch set 4 V +1 01/10/17, 10:16 Completed build in 07m 00s on Tue, 10 Jan, 11:16 AM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6380

  11. Susi Moog voted on patch set 4 CR +1 V +1 01/10/17, 10:17

  12. Andreas Kienast commented on patch set 4 CR -1 01/10/17, 11:26

    Important-79221-UseGlobalsDollarInsteadOfTYPO3jQuery.rst:19

    Why Typ*o*Script?
  13. Susi Moog commented on patch set 4 01/10/17, 11:55

    Important-79221-UseGlobalsDollarInsteadOfTYPO3jQuery.rst:19 Reply

    Because this is the full list of valid values for index: TypoScript|TSConfig|TCA|FlexForm|LocalConfiguration|Fluid|FAL|Database|JavaScript|PHP-API|Frontend|Backend|CLI|RTE (and everything with ext: in front) And TypoScript is correct because it has an impact if you set specific typoscript settings.
  14. Andreas Kienast voted on patch set 4 CR +1 01/10/17, 12:03

  15. Georg Ringer voted on patch set 4 CR +2 V +2 01/10/17, 12:32

  16. Gerrit merged patch set 4 01/10/17, 12:32