51212[TASK] Use $ instead of TYPO3.jQuery
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Andreas Kienast +1
- Susi Moog +1
-
Verified V +2
- Georg Ringer +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 18
- typo3/sysext/backend/Resources/Private/Templates/File/ReplaceFile.html1+3 −3
- typo3/sysext/backend/Resources/Public/JavaScript/extjs/components/pagetree/javascript/nodeui.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectTreeElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Wizard/Colorpicker.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/backend.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngineFlexForm.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ImageManipulation.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/jquery.clearable.js+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/jsfunc.inline.js+51 −53
- typo3/sysext/backend/Resources/Public/JavaScript/jsfunc.tbe_editor.js+5 −5
- typo3/sysext/backend/Resources/Public/JavaScript/LoginRefresh.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Modal.js+1 −1
- typo3/sysext/core/Classes/Page/PageRenderer.php+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Important-79221-UseGlobalsDollarInsteadOfTYPO3jQuery.rst2new+19 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap/bootstrap.js+1 −1
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/Main.js+2 −2
- typo3/sysext/recycler/Resources/Public/JavaScript/Recycler.js+1 −1
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+5 −5
Review log 1216
-
Benni Mack uploaded patch set 1 01/09/17, 09:15
-
TYPO3com voted on patch set 1 V +1 01/09/17, 09:19 Completed build in 04m 20s on Mon, 9 Jan, 10:19 AM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6316
-
Wouter Wolters commented on patch set 1 01/09/17, 09:23
-
Benni Mack commented on patch set 2 01/09/17, 12:23
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 01/09/17, 12:27 Completed build in 04m 07s on Mon, 9 Jan, 01:27 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6327
-
Benni Mack updated the commit message in patch set 3 01/09/17, 15:44
-
TYPO3com voted on patch set 3 V +1 01/09/17, 15:49 Completed build in 04m 42s on Mon, 9 Jan, 04:49 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6339
-
Susi Moog commented on patch set 3 CR +1 V +1 01/09/17, 16:25
maybe add an important rst because of the pagerenderer change. -
Benni Mack uploaded patch set 4 01/10/17, 10:09
-
TYPO3com voted on patch set 4 V +1 01/10/17, 10:16 Completed build in 07m 00s on Tue, 10 Jan, 11:16 AM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6380
-
Susi Moog voted on patch set 4 CR +1 V +1 01/10/17, 10:17
-
Andreas Kienast commented on patch set 4 CR -1 01/10/17, 11:26
Important-79221-UseGlobalsDollarInsteadOfTYPO3jQuery.rst:19Why Typ*o*Script? -
Susi Moog commented on patch set 4 01/10/17, 11:55
Important-79221-UseGlobalsDollarInsteadOfTYPO3jQuery.rst:19ReplyBecause this is the full list of valid values for index: TypoScript|TSConfig|TCA|FlexForm|LocalConfiguration|Fluid|FAL|Database|JavaScript|PHP-API|Frontend|Backend|CLI|RTE (and everything with ext: in front) And TypoScript is correct because it has an impact if you set specific typoscript settings. -
Andreas Kienast voted on patch set 4 CR +1 01/10/17, 12:03
-
Georg Ringer voted on patch set 4 CR +2 V +2 01/10/17, 12:32
-
Gerrit merged patch set 4 01/10/17, 12:32
ReplaceFile.html:22