Review main Merged

51214[TASK] Remove hardcoded ContextHelpWindows settings

Wouter Wolters CR +2 V +2 Easy +3 −12 updated 01/09/17, 10:50

Commit message

The values are hardcoded and not replaceable. We can put the
hardcoded values in JavaScript directly.

Review

  • Code review CR +2
    • Susi Moog +2
    • Benni Mack +1
  • Verified V +2
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 57

  1. Wouter Wolters uploaded patch set 1 01/09/17, 10:28

  2. Wouter Wolters updated the commit message in patch set 2 01/09/17, 10:29

  3. TYPO3com voted on patch set 1 V +1 01/09/17, 10:32 Completed build in 04m 14s on Mon, 9 Jan, 11:32 AM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6318

  4. TYPO3com voted on patch set 2 V +1 01/09/17, 10:34 Completed build in 04m 32s on Mon, 9 Jan, 11:34 AM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6319

  5. Benni Mack voted on patch set 2 CR +1 V +1 01/09/17, 10:35

  6. Susi Moog voted on patch set 2 CR +2 V +2 01/09/17, 10:50

  7. Gerrit merged patch set 2 01/09/17, 10:50