Review main Merged

51223[FEATURE] Preview of plugins in the backend

Georg Ringer CR +2 V +2 Easy +39 −1 updated 02/02/17, 14:49

Commit message

It is now possible to render the preview of plugins
just like of regular content elements.

Review

  • Code review CR +2
    • Markus Klein +2
    • Josef Glatz +1
    • Susi Moog +1
  • Verified V +2
    • Markus Klein +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1215

  1. Georg Ringer uploaded patch set 1 01/09/17, 19:12

  2. TYPO3com voted on patch set 1 V +1 01/09/17, 19:18 Completed build in 05m 31s on Mon, 9 Jan, 08:18 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6351

  3. Frans Saris voted on patch set 1 CR +1 01/09/17, 21:03

  4. Markus Klein updated the commit message in patch set 2 01/18/17, 12:03

  5. Markus Klein commented on patch set 2 01/18/17, 12:05

    PageLayoutView.php:1691

    must be on next line (CGL)

    PageLayoutView.php:1692

    not needed, is covered by !empty below

    Feature-79225-PluginPreviewWithFluid.rst:4

    add spaces
  6. Markus Klein commented on patch set 3 01/18/17, 12:07

    Published edit on patch set 2.
  7. Markus Klein voted on patch set 3 CR +1 01/18/17, 12:07

  8. TYPO3com voted on patch set 2 V +1 01/18/17, 12:10 Completed build in 06m 00s on Wed, 18 Jan, 01:10 PM Test Summary: 54981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6766

  9. TYPO3com voted on patch set 3 V +1 01/18/17, 12:11 Completed build in 04m 40s on Wed, 18 Jan, 01:11 PM Test Summary: 54981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6767

  10. Claus Due commented on patch set 3 01/19/17, 12:53

    This one relates to https://review.typo3.org/#/c/50389/ which I would greatly appreciate if you could both review and evaluate. Replacing the preview rendering pattern with that merge request would exactly allow for a "plugin preview renderer" with extended capabilities / custom implementations, rather than merely allowing a custom Fluid template file to be used as preview. Georg, if you need to discuss that one with me, I'm available!
  11. Josef Glatz voted on patch set 3 CR +1 01/29/17, 12:04

  12. Susi Moog voted on patch set 3 CR +1 V +1 02/02/17, 14:36

  13. Susi Moog commented on patch set 3 02/02/17, 14:37

    I love it. And it's small enough that it could still make it into 8 (please ;)). For the bigger change from Claus I'd say that may still be valid and done after this change.
  14. Markus Klein commented on patch set 3 CR +2 V +2 02/02/17, 14:48

    I agree
  15. Gerrit merged patch set 3 02/02/17, 14:49