Review main Merged

51236[BUGFIX] Correctly resolve dots inside flexform field names

Christian Weiske CR +2 V +2 Easy +13 −2 updated 11/27/17, 21:54

Commit message

When a flexform field index attribute contained a dot, only
the last value was kept.
We now correctly append the new values to the existing ones now.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Henning Liebe +1
    • Susi Moog +1
  • Verified V +2
    • Wouter Wolters +2
    • Henning Liebe +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1419

  1. Christian Weiske uploaded patch set 1 01/10/17, 13:25

  2. TYPO3com voted on patch set 1 V +1 01/10/17, 13:32 Completed build in 06m 50s on Tue, 10 Jan, 02:32 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6394

  3. Tymoteusz Motylewski updated the commit message in patch set 2 07/08/17, 19:11

  4. Tymoteusz Motylewski rebased onto patch set 3 07/08/17, 19:11

  5. TYPO3com voted on patch set 2 V +1 07/08/17, 19:22 Completed build in 11m 20s on Sat, 8 Jul, 09:22 PM Test Summary: 56775 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13055

  6. TYPO3com voted on patch set 3 V +1 07/08/17, 19:23 Completed build in 11m 27s on Sat, 8 Jul, 09:23 PM Test Summary: 56775 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13056

  7. Christian Weiske uploaded patch set 4 08/18/17, 07:34

  8. TYPO3com voted on patch set 4 V +1 08/18/17, 07:46 Completed build in 11m 11s on Fri, 18 Aug, 09:46 AM Test Summary: 57575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13795

  9. Susi Moog voted on patch set 4 CR +1 V +1 11/27/17, 12:46

  10. Sebastian Hofer voted on patch set 4 CR +1 11/27/17, 20:55

  11. Susi Moog updated the commit message in patch set 5 11/27/17, 21:42

  12. Wouter Wolters voted on patch set 5 CR +1 V +1 11/27/17, 21:42

  13. Susi Moog commented on patch set 5 11/27/17, 21:42

    Would not backport to 7.6 - too risky.
  14. Susi Moog voted on patch set 5 CR +1 V +1 11/27/17, 21:42

  15. TYPO3com voted on patch set 5 V +1 11/27/17, 21:51 Completed build in 09m 30s on Mon, 27 Nov, 10:51 PM Test Summary: 56814 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16743

  16. Henning Liebe voted on patch set 5 CR +1 V +1 11/27/17, 21:53

  17. Wouter Wolters voted on patch set 5 CR +2 V +2 11/27/17, 21:54

  18. Gerrit merged patch set 5 11/27/17, 21:54

  19. Wouter Wolters commented on patch set 6 11/27/17, 21:54

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit b9e2d765d1613f423b387a0607e78c0dc203098c