51237[BUGFIX] Correctly show sub item indicator in svg tree
Commit message
Review
-
Code review CR +2
- Tymoteusz Motylewski +2
- Thomas Maroschik +1
-
Verified V +2
- Tymoteusz Motylewski +2
- Thomas Maroschik +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1822
-
Thorben Nissen uploaded patch set 1 01/10/17, 13:25
-
Thorben Nissen uploaded patch set 2 01/10/17, 13:28
-
TYPO3com voted on patch set 1 V +1 01/10/17, 13:32 Completed build in 06m 35s on Tue, 10 Jan, 02:32 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6395
-
TYPO3com voted on patch set 2 V +1 01/10/17, 13:33 Completed build in 04m 33s on Tue, 10 Jan, 02:33 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6396
-
Tymoteusz Motylewski commented on patch set 2 01/10/17, 14:58
this is probably a regression introduced with https://review.typo3.org/50813 -
Tymoteusz Motylewski commented on patch set 2 CR -1 V -1 01/10/17, 15:22
not working as expected (e.g. try checking parent and child, and then unchecking child - "intremediate" state will be removed from the rootline. The previous implementation was visiting nodes in the different order (children before siblings). -
Thorben Nissen commented on patch set 2 01/10/17, 15:24
Reading the change from https://review.typo3.org/50813 I would say, yes. This is a regression. The backend was changed but the "frontend" was missed. Ok. I take a look again at the code. -
Tymoteusz Motylewski commented on patch set 2 01/10/17, 15:45
It seems that there are more things wrong: - the node.children is *not defined* any more, so any code using it needs to be refactored - rootNode is not being set anymore, so any code referencing it needs to be refactored - function descendantsBefore can be removed as it's not used any more - function eachAfter depends on "children" being set, so it also needs to be refactored -
Thorben Nissen uploaded patch set 3 01/11/17, 11:56
-
Thorben Nissen commented on patch set 3 01/11/17, 11:58
Selecting and unselecting nodes anywhere in the tree not works as expected, as far as I can see. eachAfter seams to be a function of d3js, so I think we can not removed it, but I found no usages so far. -
TYPO3com voted on patch set 3 V +1 01/11/17, 12:00 Completed build in 03m 47s on Wed, 11 Jan, 01:00 PM Test Summary: 54945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6476
-
Tymoteusz Motylewski commented on patch set 3 01/11/17, 12:24
looks better, 2 notes in the commentsSvgTree.js:568have you tested this method? You need to change TCA configuration for it field['config']['exclusiveKeys']. see https://docs.typo3.org/typo3cms/TCAReference/Reference/Columns/Select/Index.html?highlight=exclusivekeys#exclusivekeysSvgTree.js:573the each function probably also relays on children being set. Please check if we can use foreach here? -
Thorben Nissen uploaded patch set 4 01/11/17, 15:27
-
Thorben Nissen commented on patch set 3 01/11/17, 15:32
Now, yes. Must be forEach instead of each, but then it works. I also fixed a wrong behaviour in another case I came across: If a node is deselected but there are nodes in other sub trees selected, the root node got unselected. This works now.SvgTree.js:568ReplyThis works as expected.SvgTree.js:573ReplyThis must be forEach instead of each. -
TYPO3com voted on patch set 4 V +1 01/11/17, 15:32 Completed build in 04m 39s on Wed, 11 Jan, 04:32 PM Test Summary: 54945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6493
-
Christian Kuhn commented on patch set 4 01/11/17, 21:24
thank you! pinged tom for a second eye. -
Thomas Maroschik commented on patch set 4 01/16/17, 07:54
I'm testing this one today. -
Thorben Nissen commented on patch set 4 01/24/17, 14:07
Any updates on this? It would be great, if this makes it into the 8.6 release. -
Thomas Maroschik commented on patch set 4 01/24/17, 14:28
It's still on my list. Hopefully this evening. -
Thomas Maroschik voted on patch set 4 CR +1 V +1 01/25/17, 08:41
-
Tymoteusz Motylewski voted on patch set 4 CR +2 V +2 01/25/17, 08:59
-
Gerrit merged patch set 4 01/25/17, 08:59