51238[FEATURE] Add button to delete similar errors from sys_log
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Christian Kuhn +1
-
Verified V +2
- Susi Moog +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/belog/Classes/Controller/ToolsController.php2+20 −0
- typo3/sysext/belog/Classes/Domain/Repository/LogEntryRepository.php+26 −1
- typo3/sysext/belog/Resources/Private/Language/locallang.xlf8+15 −0
- typo3/sysext/belog/Resources/Private/Partials/Content/LogEntries.html4+14 −0
- typo3/sysext/belog/Resources/Private/Templates/Tools/Index.html+1 −0
- typo3/sysext/belog/ext_tables.php+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Feature-79235-AddButtonToDeleteSimilarErrorsFromSys_log.rstnew+16 −0
Review log 3550
Show 1725 earlier messages
-
Mathias Schreiber uploaded patch set 1 01/10/17, 13:40
-
Mathias Schreiber updated the commit message in patch set 2 01/10/17, 13:41
-
TYPO3com voted on patch set 1 V -1 01/10/17, 13:45 Completed build in 04m 48s on Tue, 10 Jan, 02:45 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6397
-
TYPO3com voted on patch set 2 V -1 01/10/17, 13:46 Completed build in 05m 09s on Tue, 10 Jan, 02:46 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6398
-
Mathias Schreiber uploaded patch set 3 01/10/17, 13:49
-
TYPO3com voted on patch set 3 V +1 01/10/17, 13:53 Completed build in 04m 18s on Tue, 10 Jan, 02:53 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6400
-
Michael Oehlhof commented on patch set 3 01/10/17, 14:26
Similar errors are not deleted, only the same. I would either change the naming or enhance the query if possible. I have some similar errors in my log which only differ in an ajaxToken in the log message. It would be great if they could be deleted with the new button. -
Susi Moog commented on patch set 3 01/10/17, 15:18
As the core has more than one method actually writing to the sys_log table with _very_ inconsistent usage of details_nr there is currently no way to cleanly identify similar errors. That would only be possible after a massive refactoring of this area of TYPO3. I agree that the naming is kind of confusing, I also wondered why closely the same looking errors were not deleted when pressing the button. I'd propose to change it to something more clear like - Delete errors with same message - Delete all errors like this -... ? -
Stephan Großberndt commented on patch set 4 01/10/17, 15:23
Published edit on patch set 3. -
TYPO3com voted on patch set 4 V -1 01/10/17, 15:28 Completed build in 04m 36s on Tue, 10 Jan, 04:28 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6402
-
Stephan Großberndt commented on patch set 4 01/10/17, 15:28
This depends on the sys_log "details" and "data" fields. If the "details" contain placeholders like %s which are vsprintf'd with contents of "data", contents of "details" is the same for multiple messages. I guess the problem with those ajaxToken messages is they are written directly to "details" instead of using "data". The fix there would rather be to put the ajaxToken into "data". -
Stephan Großberndt commented on patch set 5 01/10/17, 15:29
Published edit on patch set 4. -
Susi Moog commented on patch set 5 01/10/17, 15:33
SQL errors are logged via "SQL error: '%s' (%s)" which in turn means: once you press that button all SQL errors that have ever happened no matter where disappear, don't they? -
TYPO3com voted on patch set 5 V +1 01/10/17, 15:34 Completed build in 04m 50s on Tue, 10 Jan, 04:34 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6403
-
Stephan Großberndt commented on patch set 5 01/10/17, 15:38
Yes. So deleting only based on "details" is wrong. Using the complete vsprintf'd string will lead to not being able to delete similar messages - the hard part is defining the similarity. -
Susi Moog commented on patch set 5 CR -2 01/10/17, 15:50
just talked with Mattes who has an idea on how to fix it. Blocking until he does ;) -
Mathias Schreiber uploaded patch set 6 01/10/17, 17:01
-
TYPO3com voted on patch set 6 V +1 01/10/17, 17:06 Completed build in 05m 06s on Tue, 10 Jan, 06:06 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6405
-
Mathias Schreiber uploaded patch set 7 01/10/17, 17:55
-
TYPO3com voted on patch set 7 V -1 01/10/17, 18:00 Completed build in 04m 33s on Tue, 10 Jan, 06:59 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6408
-
Mathias Schreiber uploaded patch set 8 01/10/17, 18:18
-
Susi Moog voted on patch set 8 CR +1 01/10/17, 18:18
-
TYPO3com voted on patch set 8 V +1 01/10/17, 18:22 Completed build in 04m 03s on Tue, 10 Jan, 07:22 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6409
-
Michael Oehlhof commented on patch set 8 01/10/17, 19:01
locallang.xlf:382What about deleted warnings ? Did they also get the "error" message? -
Susi Moog commented on patch set 9 01/10/17, 19:03
Published edit on patch set 8.
-
Susi Moog voted on patch set 9 CR +1 01/10/17, 19:03
-
TYPO3com voted on patch set 9 V +1 01/10/17, 19:07 Completed build in 04m 17s on Tue, 10 Jan, 08:07 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6412
-
Susi Moog voted on patch set 9 V +1 01/11/17, 07:50
-
Christian Kuhn commented on patch set 9 CR -1 01/11/17, 08:38
on it. -
Mathias Schreiber uploaded patch set 10 01/11/17, 09:04
-
Mathias Schreiber uploaded patch set 11 01/11/17, 09:05
-
TYPO3com voted on patch set 10 V -1 01/11/17, 09:09 Completed build in 05m 05s on Wed, 11 Jan, 10:09 AM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6457
-
TYPO3com voted on patch set 11 V -1 01/11/17, 09:10 Completed build in 04m 32s on Wed, 11 Jan, 10:10 AM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6458
-
Mathias Schreiber uploaded patch set 12 01/11/17, 09:46
-
TYPO3com voted on patch set 12 V +1 01/11/17, 09:51 Completed build in 04m 32s on Wed, 11 Jan, 10:51 AM Test Summary: 54945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6464
-
Susi Moog voted on patch set 12 CR +1 01/11/17, 10:02
-
Christian Kuhn uploaded patch set 13 01/11/17, 10:42
-
Christian Kuhn voted on patch set 13 CR +1 V +1 01/11/17, 10:42
-
Daniel Windloff commented on patch set 13 01/11/17, 10:44
ToolsController.php:39There should be some additional information about the $logEntrylocallang.xlf:373At the moment this is only one actionlocallang.xlf:376samelocallang.xlf:379sameLogEntries.html:213I would opt for the std action icon for the delete action (recycler) with an additional description. There should be also a modal (danger) like in the recycler module to confirm the deletion as the action couldn't be reverted (without backup). -
TYPO3com voted on patch set 13 V +1 01/11/17, 10:47 Completed build in 04m 38s on Wed, 11 Jan, 11:47 AM Test Summary: 54945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6469
-
Christian Kuhn commented on patch set 12 01/11/17, 11:11
ToolsController.php:39ReplyThink that's fine for now. You pushed the button and receive a message how many rows were affected. Should do, I think.locallang.xlf:373Replyoklocallang.xlf:376Replyno, that's actually a plural. pushing that button may delete multiple rows.LogEntries.html:213Replymmmh, the button text starts with "Delele" ... guess it's rather obvious what happens if you press it. This is an admin only module, I'd opt to not have a confirm on that and keep the text. -
Christian Kuhn uploaded patch set 14 01/11/17, 11:11
-
Christian Kuhn commented on patch set 12 01/11/17, 11:13
locallang.xlf:373Replyah snap. there is already an action called 'action' ... guess we should better keep 'actions' here ... -
Christian Kuhn uploaded patch set 15 01/11/17, 11:13
-
Christian Kuhn voted on patch set 15 CR +1 V +1 01/11/17, 11:14
-
TYPO3com voted on patch set 14 V +1 01/11/17, 11:16 Completed build in 04m 37s on Wed, 11 Jan, 12:16 PM Test Summary: 54945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6471
-
TYPO3com voted on patch set 15 V +1 01/11/17, 11:19 Completed build in 05m 34s on Wed, 11 Jan, 12:19 PM Test Summary: 54945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6472
-
Daniel Windloff commented on patch set 15 01/11/17, 11:43
LogEntries.html:213ReplyYes the text is obvious, but a user needs perhaps a second view. The confirmation of the deletion is also used in other admin only modules (e.g. scheduler) so I would prefer to add it. -
Susi Moog commented on patch set 15 CR +2 V +2 01/11/17, 11:49
locallang.xlf:373Replythis is meant to be the column for all row related actions, so the wording here is correct.LogEntries.html:213ReplyI'd also say as this is admin only, the confirmation is not necessary. As for the icons: the whole table needs a ui rework (word-wrap, column width, naming things ...). I'll take the feature as it is now as I see all that in a separate step. -
Gerrit merged patch set 15 01/11/17, 11:49