51250[TASK] Extbase commands do not need to ensure admin role
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Daniel Goerz +1
- Mathias Brodala +1
-
Verified V +2
- Georg Ringer +2
- Daniel Goerz +1
- Mathias Brodala +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1318
-
Benni Mack uploaded patch set 1 01/10/17, 20:46
-
TYPO3com voted on patch set 1 V +1 01/10/17, 20:55 Completed build in 08m 34s on Tue, 10 Jan, 09:55 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6421
-
Benni Mack commented on patch set 2 01/10/17, 23:49
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 01/10/17, 23:56 Completed build in 06m 33s on Wed, 11 Jan, 12:55 AM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6452
-
Benni Mack commented on patch set 2 CR -1 01/11/17, 00:07
needs testing and a issue number -
Benni Mack uploaded patch set 3 02/02/17, 05:49
-
Benni Mack updated the commit message in patch set 4 02/02/17, 05:49
-
TYPO3com voted on patch set 3 V +1 02/02/17, 05:55 Completed build in 05m 57s on Thu, 2 Feb, 06:55 AM Test Summary: 55727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7320
-
TYPO3com voted on patch set 4 V +1 02/02/17, 05:55 Completed build in 06m 08s on Thu, 2 Feb, 06:55 AM Test Summary: 55727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7321
-
Benni Mack uploaded patch set 5 03/27/17, 07:49
-
Mathias Brodala commented on patch set 5 03/27/17, 07:52
CommandController.php:280Can't we drop this part then?CommandController.php:296Same here. -
Benni Mack commented on patch set 5 03/27/17, 07:54
CommandController.php:280Replywell, I tried to do the "strict deprecation", if people use it that's fine, but it just does not make sense anymore. You never know if people create their own $BE_USER object in CLI mode to simulate a different user or whatever. so a simple deprecation is the safest way to ensure to NOT break anything. -
Mathias Brodala commented on patch set 5 CR +1 03/27/17, 07:59
CommandController.php:280ReplyAlright, makes sense. -
TYPO3com voted on patch set 5 V +1 03/27/17, 08:00 Completed build in 10m 18s on Mon, 27 Mar, 10:00 AM Test Summary: 56517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9608
-
Daniel Goerz voted on patch set 5 CR +1 V +1 03/27/17, 08:13
-
Mathias Brodala voted on patch set 5 V +1 03/27/17, 08:24
-
Georg Ringer voted on patch set 5 CR +2 V +2 03/27/17, 08:33
-
Gerrit merged patch set 5 03/27/17, 08:33