Review main Merged

51250[TASK] Extbase commands do not need to ensure admin role

Benni Mack CR +2 V +2 Easy +40 −0 updated 03/27/17, 08:33

Commit message

The methods in Extbase's command controller to request
the admin role for $BE_USER are not needed anymore,
because CLI users are always admins nowadays.

The methods are therefore marked as deprecated.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Daniel Goerz +1
    • Mathias Brodala +1
  • Verified V +2
    • Georg Ringer +2
    • Daniel Goerz +1
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1318

  1. Benni Mack uploaded patch set 1 01/10/17, 20:46

  2. TYPO3com voted on patch set 1 V +1 01/10/17, 20:55 Completed build in 08m 34s on Tue, 10 Jan, 09:55 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6421

  3. Benni Mack commented on patch set 2 01/10/17, 23:49

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V +1 01/10/17, 23:56 Completed build in 06m 33s on Wed, 11 Jan, 12:55 AM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6452

  5. Benni Mack commented on patch set 2 CR -1 01/11/17, 00:07

    needs testing and a issue number
  6. Benni Mack uploaded patch set 3 02/02/17, 05:49

  7. Benni Mack updated the commit message in patch set 4 02/02/17, 05:49

  8. TYPO3com voted on patch set 3 V +1 02/02/17, 05:55 Completed build in 05m 57s on Thu, 2 Feb, 06:55 AM Test Summary: 55727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7320

  9. TYPO3com voted on patch set 4 V +1 02/02/17, 05:55 Completed build in 06m 08s on Thu, 2 Feb, 06:55 AM Test Summary: 55727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7321

  10. Benni Mack uploaded patch set 5 03/27/17, 07:49

  11. Mathias Brodala commented on patch set 5 03/27/17, 07:52

    CommandController.php:280

    Can't we drop this part then?

    CommandController.php:296

    Same here.
  12. Benni Mack commented on patch set 5 03/27/17, 07:54

    CommandController.php:280 Reply

    well, I tried to do the "strict deprecation", if people use it that's fine, but it just does not make sense anymore. You never know if people create their own $BE_USER object in CLI mode to simulate a different user or whatever. so a simple deprecation is the safest way to ensure to NOT break anything.
  13. Mathias Brodala commented on patch set 5 CR +1 03/27/17, 07:59

    CommandController.php:280 Reply

    Alright, makes sense.
  14. TYPO3com voted on patch set 5 V +1 03/27/17, 08:00 Completed build in 10m 18s on Mon, 27 Mar, 10:00 AM Test Summary: 56517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9608

  15. Daniel Goerz voted on patch set 5 CR +1 V +1 03/27/17, 08:13

  16. Mathias Brodala voted on patch set 5 V +1 03/27/17, 08:24

  17. Georg Ringer voted on patch set 5 CR +2 V +2 03/27/17, 08:33

  18. Gerrit merged patch set 5 03/27/17, 08:33