Review main Merged

51265[BUGFIX] CacheHashCalculator does not exclude ADMCMD arguments

Oliver Hader CR +2 V +2 Easy +5 −3 updated 01/11/17, 16:35

Commit message

ADMCMD arguments are not filtered when calculating the cache-hash
which results in a page not found error. The behavior can be
triggered by creating and opening a preview link in the workspace
module which implicitly sets ADMCMD_previewWS during runtime.

Review

  • Code review CR +2
    • Benni Mack +2
    • Mathias Brodala +1
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Oliver Hader uploaded patch set 1 01/11/17, 14:19

  2. Susi Moog voted on patch set 1 CR +1 V +1 01/11/17, 14:23

  3. TYPO3com voted on patch set 1 V +1 01/11/17, 14:24 Completed build in 05m 40s on Wed, 11 Jan, 03:24 PM Test Summary: 54945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6487

  4. Mathias Brodala commented on patch set 1 01/11/17, 14:30

    CacheHashCalculator.php:172

    This should be updated accordingly.
  5. Oliver Hader uploaded patch set 2 01/11/17, 14:37

  6. Mathias Brodala voted on patch set 2 CR +1 01/11/17, 14:39

  7. TYPO3com voted on patch set 2 V +1 01/11/17, 14:42 Completed build in 05m 19s on Wed, 11 Jan, 03:42 PM Test Summary: 54945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6490

  8. Susi Moog voted on patch set 2 CR +1 V +1 01/11/17, 16:01

  9. Benni Mack voted on patch set 2 CR +2 V +2 01/11/17, 16:35

  10. Gerrit merged patch set 2 01/11/17, 16:35