Review main Merged

51268[TASK] Code cleanup for RteHtmlParser

Benni Mack CR +2 V +2 Hard +200 −110 updated 01/29/17, 15:43

Commit message

Several code parts have been cleaned up and sorted into separate methods
to ensure readability.

Certain options defined by procOptions are now initialized at the very
beginning, before all transformations.

Resolving modes are moved into a separate method, as well as configuring
the entry- and exit-HTML parser, making the main method easier to read.

Cleaning up content and adding <p> tags around "simple" content lines
has been split up as well to avoid code duplication.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 913

  1. Benni Mack uploaded patch set 1 01/11/17, 15:58

  2. TYPO3com voted on patch set 1 V -1 01/11/17, 16:02 Completed build in 03m 56s on Wed, 11 Jan, 05:01 PM Test Summary: 54945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6494

  3. Susi Moog commented on patch set 1 01/11/17, 16:09

    RteHtmlParser.php:114

    this sentence is broken.

    RteHtmlParser.php:173

    what?

    RteHtmlParser.php:191

    if

    RteHtmlParser.php:253

    if

    RteHtmlParser.php:291

    are

    RteHtmlParser.php:293

    only

    RteHtmlParser.php:1136

    array_intersect_key instead?

    RteHtmlParser.php:1145

    array_intersect?
  4. Benni Mack uploaded patch set 2 01/11/17, 16:56

  5. TYPO3com voted on patch set 2 V +1 01/11/17, 17:00 Completed build in 04m 16s on Wed, 11 Jan, 06:00 PM Test Summary: 54945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6503

  6. Benni Mack updated the commit message in patch set 3 01/11/17, 17:11

  7. TYPO3com voted on patch set 3 V +1 01/11/17, 17:16 Completed build in 05m 09s on Wed, 11 Jan, 06:16 PM Test Summary: 54945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6505

  8. Susi Moog commented on patch set 4 01/11/17, 17:52

    Published edit on patch set 3.
  9. Susi Moog voted on patch set 4 CR +1 V +1 01/11/17, 17:52

  10. TYPO3com voted on patch set 4 V +1 01/11/17, 17:58 Completed build in 06m 23s on Wed, 11 Jan, 06:58 PM Test Summary: 54945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6508

  11. Christian Kuhn voted on patch set 4 CR +2 V +2 01/11/17, 20:24

  12. Gerrit merged patch set 4 01/11/17, 20:24

  13. Frans Saris commented on patch set 5 01/29/17, 15:43

    post -1

    RteHtmlParser.php:1138

    This check is wrong, the 2the array needs to be flipped so the keys are used $tagAttributes = array_intersect_key($tagAttributes, array_flip($this->allowedAttributesForParagraphTags));