Review main Merged Breaking

51272[!!!][TASK] Migrate pages_language_overlay into pages

Benni Mack CR +2 V +2 Nightmare +1691 −976 updated 06/06/19, 16:00

Commit message

The patch migrates all data from pages_language_overlay into pages,
and moves all API calls to overlay pages.

The following restrictions are set:
* Backend is always showing pages only for "sys_language_uid=0"
  for the page tree, element browser (e.g. "linking to default
  language page"), except where explicitly requested like the Page
  Module => Languages view.
* pid and sorting are always the same for all translations and
  their default language page
* Elements on a page are always keeping the field "pid" to the
  default language page (no change)
* Permission checks for Backend users are always made against
  the default language page (perms_* fields and webmounts)

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Frank Nägler +1
    • Christian Kuhn +1
    • Frans Saris +1
  • Verified V +2
    • Andreas Kienast +2
    • Frank Nägler +1
    • Christian Kuhn +1
    • Frans Saris +1
    • TYPO3com +1 CI

Issues 1

Files 86

Show 66 more files

Review log 139240

Show 119215 earlier messages
  1. Benni Mack uploaded patch set 1 01/11/17, 19:12

  2. TYPO3com voted on patch set 1 V -1 01/11/17, 19:16 Completed build in 04m 17s on Wed, 11 Jan, 08:16 PM Test Summary: 72 of 54945 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6514

  3. Benni Mack uploaded patch set 2 01/11/17, 20:59

  4. TYPO3com voted on patch set 2 V -1 01/11/17, 21:05 Completed build in 05m 57s on Wed, 11 Jan, 10:05 PM Test Summary: 48 of 54975 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6524

  5. Benni Mack uploaded patch set 3 01/11/17, 21:31

  6. TYPO3com voted on patch set 3 V -1 01/11/17, 21:36 Completed build in 04m 32s on Wed, 11 Jan, 10:35 PM Test Summary: 48 of 54975 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6530

  7. Benni Mack uploaded patch set 4 01/11/17, 21:59

  8. TYPO3com voted on patch set 4 V -1 01/11/17, 22:04 Completed build in 04m 48s on Wed, 11 Jan, 11:04 PM Test Summary: 48 of 54975 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6532

  9. Benni Mack uploaded patch set 5 01/11/17, 22:43

  10. TYPO3com voted on patch set 5 V -1 01/11/17, 22:43 Completed build in 10s on Wed, 11 Jan, 11:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6536

  11. Christian Kuhn uploaded patch set 6 04/17/17, 17:43

  12. TYPO3com voted on patch set 6 V -1 04/17/17, 17:51 Completed build in 07m 45s on Mon, 17 Apr, 07:51 PM Test Summary: 130 of 56626 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10629

  13. Christian Kuhn commented on patch set 6 04/17/17, 17:53

    rebased, solved a bunch of conflicts
  14. Benni Mack uploaded patch set 7 04/20/17, 18:04

  15. TYPO3com voted on patch set 7 V -1 04/20/17, 18:19 Completed build in 15m 13s on Thu, 20 Apr, 08:19 PM Test Summary: 130 of 55892 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10805

  16. Benni Mack uploaded patch set 8 05/17/17, 05:16

  17. TYPO3com voted on patch set 8 V -1 05/17/17, 05:22 Completed build in 06m 16s on Wed, 17 May, 07:22 AM Test Summary: 130 of 55852 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11523

  18. Benni Mack uploaded patch set 9 08/15/17, 13:09

  19. TYPO3com voted on patch set 9 V -1 08/15/17, 13:33 Completed build in 24m 37s on Tue, 15 Aug, 03:33 PM Test Summary: 368 of 57806 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13728

  20. Benni Mack uploaded patch set 10 08/30/17, 09:32

  21. TYPO3com voted on patch set 10 V -1 08/30/17, 09:32 Completed build in 15s on Wed, 30 Aug, 11:32 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14100

  22. Benni Mack uploaded patch set 11 08/30/17, 09:33

  23. TYPO3com voted on patch set 11 V -1 08/30/17, 11:04 Completed build in 1h 30m 30s on Wed, 30 Aug, 01:04 PM Test Summary: 818 of 58448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14101

  24. Benni Mack uploaded patch set 12 09/08/17, 21:01

  25. TYPO3com voted on patch set 12 V -1 09/08/17, 21:13 Completed build in 12m 21s on Fri, 8 Sep, 11:13 PM Test Summary: 755 of 57180 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14585

  26. Anja Leichsenring uploaded patch set 13 09/08/17, 22:26

  27. TYPO3com voted on patch set 13 V -1 09/08/17, 22:26 Completed build in 15s on Sat, 9 Sep, 12:26 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14600

  28. Benni Mack uploaded patch set 14 09/09/17, 09:29

  29. TYPO3com voted on patch set 14 V -1 09/09/17, 09:30 Completed build in 41s on Sat, 9 Sep, 11:30 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14624

  30. Anja Leichsenring uploaded patch set 15 09/09/17, 09:53

  31. TYPO3com voted on patch set 15 V -1 09/09/17, 09:54 Completed build in 16s on Sat, 9 Sep, 11:54 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14630

  32. Anja Leichsenring uploaded patch set 16 09/09/17, 10:06

  33. TYPO3com voted on patch set 16 V -1 09/09/17, 10:37 Completed build in 31m 04s on Sat, 9 Sep, 12:37 PM Test Summary: 235 of 58521 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14631

  34. Anja Leichsenring uploaded patch set 17 09/09/17, 11:26

  35. TYPO3com voted on patch set 17 V -1 09/09/17, 11:54 Completed build in 27m 16s on Sat, 9 Sep, 01:54 PM Test Summary: 450 of 58521 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14645

  36. Anja Leichsenring uploaded patch set 18 09/09/17, 12:36

  37. Anja Leichsenring uploaded patch set 19 09/09/17, 12:42

  38. Anja Leichsenring uploaded patch set 20 09/09/17, 12:46

  39. TYPO3com voted on patch set 19 V -1 09/09/17, 12:46 Completed build in 03m 48s on Sat, 9 Sep, 02:46 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14664

  40. TYPO3com voted on patch set 20 V -1 09/09/17, 12:46 Completed build in 22s on Sat, 9 Sep, 02:46 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14665

  41. TYPO3com voted on patch set 18 V -1 09/09/17, 12:59 Completed build in 23m 37s on Sat, 9 Sep, 02:59 PM Test Summary: 222 of 58551 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14663

  42. Anja Leichsenring uploaded patch set 21 09/09/17, 13:02

  43. TYPO3com voted on patch set 21 V -1 09/09/17, 13:21 Completed build in 18m 36s on Sat, 9 Sep, 03:21 PM Test Summary: 222 of 58551 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14667

  44. Anja Leichsenring uploaded patch set 22 09/09/17, 21:33

  45. TYPO3com voted on patch set 22 V -1 09/09/17, 21:34 Completed build in 20s on Sat, 9 Sep, 11:34 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14753

  46. Benni Mack uploaded patch set 23 09/10/17, 13:57

  47. TYPO3com voted on patch set 23 V -1 09/10/17, 14:15 Completed build in 17m 39s on Sun, 10 Sep, 04:15 PM Test Summary: 229 of 58539 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14831

  48. Benni Mack uploaded patch set 24 09/27/17, 05:30

  49. TYPO3com voted on patch set 24 V -1 09/27/17, 05:44 Completed build in 13m 40s on Wed, 27 Sep, 07:44 AM Test Summary: 154 of 57158 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15162

  50. Benni Mack uploaded patch set 25 10/02/17, 23:06

  51. TYPO3com voted on patch set 25 V -1 10/02/17, 23:20 Completed build in 14m 16s on Tue, 3 Oct, 01:20 AM Test Summary: 154 of 57159 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15285

  52. Benni Mack uploaded patch set 26 10/05/17, 05:17

  53. TYPO3com voted on patch set 26 V -1 10/05/17, 05:27 Completed build in 09m 19s on Thu, 5 Oct, 07:27 AM Test Summary: 156 of 56945 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15377

  54. Benni Mack uploaded patch set 27 10/09/17, 10:31

  55. TYPO3com voted on patch set 27 V -1 10/09/17, 10:41 Completed build in 09m 33s on Mon, 9 Oct, 12:41 PM Test Summary: 156 of 56981 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15474

  56. Benni Mack uploaded patch set 28 10/09/17, 10:58

  57. TYPO3com voted on patch set 28 V -1 10/09/17, 11:06 Completed build in 08m 06s on Mon, 9 Oct, 01:06 PM Test Summary: 36 of 56981 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15475

  58. Benni Mack uploaded patch set 29 10/09/17, 14:51

  59. TYPO3com voted on patch set 29 V -1 10/09/17, 15:02 Completed build in 10m 55s on Mon, 9 Oct, 05:02 PM Test Summary: 39 of 56981 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15488

  60. TYPO3com commented on patch set 29 10/09/17, 18:24 Completed build in 3h 43m 57s on Mon, 9 Oct, 08:24 PM Test Summary: 30 of 56981 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15488

  61. Benni Mack uploaded patch set 30 10/09/17, 18:29

  62. Benni Mack uploaded patch set 31 10/09/17, 18:31

  63. TYPO3com voted on patch set 30 V -1 10/09/17, 18:39 Completed build in 09m 58s on Mon, 9 Oct, 08:39 PM Test Summary: 30 of 56981 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15496

  64. TYPO3com voted on patch set 31 V -1 10/09/17, 18:41 Completed build in 10m 26s on Mon, 9 Oct, 08:41 PM Test Summary: 30 of 56981 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15497

  65. Benni Mack uploaded patch set 32 10/09/17, 18:45

  66. TYPO3com voted on patch set 32 V -1 10/09/17, 18:56 Completed build in 10m 17s on Mon, 9 Oct, 08:56 PM Test Summary: 30 of 56981 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15498

  67. Benni Mack uploaded patch set 33 10/09/17, 19:29

  68. Benni Mack uploaded patch set 34 10/09/17, 19:30

  69. TYPO3com voted on patch set 33 V -1 10/09/17, 19:40 Completed build in 10m 43s on Mon, 9 Oct, 09:40 PM Test Summary: 30 of 56981 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15500

  70. TYPO3com voted on patch set 34 V -1 10/09/17, 19:42 Completed build in 11m 15s on Mon, 9 Oct, 09:42 PM Test Summary: 30 of 56981 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15501

  71. Benni Mack uploaded patch set 35 10/10/17, 06:03

  72. TYPO3com voted on patch set 35 V -1 10/10/17, 06:15 Completed build in 11m 40s on Tue, 10 Oct, 08:15 AM Test Summary: 30 of 56999 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15504

  73. Oliver Hader uploaded patch set 36 10/11/17, 19:52

  74. Oliver Hader uploaded patch set 37 10/11/17, 19:54

  75. TYPO3com voted on patch set 36 V -1 10/11/17, 20:03 Completed build in 10m 40s on Wed, 11 Oct, 10:03 PM Test Summary: 28 of 56999 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15562

  76. TYPO3com voted on patch set 37 V -1 10/11/17, 20:05 Completed build in 11m 23s on Wed, 11 Oct, 10:05 PM Test Summary: 28 of 56999 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15563

  77. Benni Mack uploaded patch set 38 10/11/17, 20:26

  78. Benni Mack uploaded patch set 39 10/11/17, 20:33

  79. TYPO3com voted on patch set 38 V -1 10/11/17, 20:35 Completed build in 08m 53s on Wed, 11 Oct, 10:35 PM Test Summary: 28 of 56999 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15564

  80. TYPO3com voted on patch set 39 V -1 10/11/17, 20:43 Completed build in 09m 24s on Wed, 11 Oct, 10:43 PM Test Summary: 28 of 56999 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15565

  81. Benni Mack uploaded patch set 40 10/13/17, 19:52

  82. TYPO3com voted on patch set 40 V -1 10/13/17, 20:01 Completed build in 08m 56s on Fri, 13 Oct, 10:01 PM Test Summary: 34 of 56999 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15623

  83. Benni Mack uploaded patch set 41 10/13/17, 20:32

  84. TYPO3com voted on patch set 41 V -1 10/13/17, 20:41 Completed build in 08m 54s on Fri, 13 Oct, 10:41 PM Test Summary: 34 of 56999 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15624

  85. Benni Mack uploaded patch set 42 10/14/17, 18:17

  86. TYPO3com voted on patch set 42 V -1 10/14/17, 18:17 Completed build in 17s on Sat, 14 Oct, 08:17 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15643

  87. Benni Mack uploaded patch set 43 10/14/17, 18:18

  88. TYPO3com voted on patch set 43 V -1 10/14/17, 18:28 Completed build in 09m 18s on Sat, 14 Oct, 08:28 PM Test Summary: 40 of 57007 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15644

  89. Benni Mack uploaded patch set 44 10/14/17, 18:54

  90. TYPO3com voted on patch set 44 V -1 10/14/17, 19:04 Completed build in 09m 05s on Sat, 14 Oct, 09:04 PM Test Summary: 20 of 57007 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15645

  91. Benni Mack uploaded patch set 45 10/14/17, 19:12

  92. TYPO3com voted on patch set 45 V -1 10/14/17, 19:22 Completed build in 09m 34s on Sat, 14 Oct, 09:22 PM Test Summary: 20 of 57007 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15646

  93. Benni Mack uploaded patch set 46 10/14/17, 20:05

  94. TYPO3com voted on patch set 46 V -1 10/14/17, 20:14 Completed build in 09m 19s on Sat, 14 Oct, 10:14 PM Test Summary: 6 of 57007 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15647

  95. Benni Mack uploaded patch set 47 10/14/17, 20:25

  96. TYPO3com voted on patch set 47 V -1 10/14/17, 20:34 Completed build in 09m 23s on Sat, 14 Oct, 10:34 PM Test Summary: 2 of 57007 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15648

  97. Benni Mack uploaded patch set 48 10/14/17, 20:45

  98. TYPO3com voted on patch set 48 V +1 10/14/17, 20:54 Completed build in 08m 56s on Sat, 14 Oct, 10:54 PM Test Summary: 56612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15649

  99. Benni Mack uploaded patch set 49 10/16/17, 12:22

  100. TYPO3com voted on patch set 49 V -1 10/16/17, 12:22 Completed build in 18s on Mon, 16 Oct, 02:22 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15670

  101. Benni Mack uploaded patch set 50 10/16/17, 12:22

  102. TYPO3com voted on patch set 50 V +1 10/16/17, 12:31 Completed build in 08m 51s on Mon, 16 Oct, 02:31 PM Test Summary: 56612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15671

  103. Benni Mack uploaded patch set 51 10/16/17, 12:37

  104. TYPO3com voted on patch set 51 V +1 10/16/17, 12:46 Completed build in 09m 00s on Mon, 16 Oct, 02:46 PM Test Summary: 56612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15672

  105. Benni Mack uploaded patch set 52 10/16/17, 16:00

  106. TYPO3com voted on patch set 52 V +1 10/16/17, 16:09 Completed build in 09m 00s on Mon, 16 Oct, 06:09 PM Test Summary: 56612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15683

  107. Christian Kuhn commented on patch set 51 10/16/17, 16:17

    TranslationConfigurationProvider.php:142

    only $row['pid'] left, rest can be deleted.

    EditDocumentController.php:1501

    this place probably has an issue that now access rights check of the page-up, but not the default lang page are applied?

    PageLayoutController.php:330

    an alternative is probably selecting where pid=$this->id and sys_language_uid > 0. But ok, you're doing that systematically everywhere.

    ext_tables.sql:33

    keep

    Default.yaml:12

    rly?
  108. Benni Mack uploaded patch set 53 10/16/17, 19:42

  109. TYPO3com voted on patch set 53 V -1 10/16/17, 19:54 Completed build in 11m 27s on Mon, 16 Oct, 09:54 PM Test Summary: 2 of 56971 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15702

  110. Benni Mack uploaded patch set 54 10/16/17, 20:08

  111. TYPO3com voted on patch set 54 V -1 10/16/17, 20:16 Completed build in 08m 44s on Mon, 16 Oct, 10:16 PM Test Summary: 1 of 56971 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15704

  112. TYPO3com voted on patch set 54 V +1 10/16/17, 20:18 Completed build in 19m 27s on Mon, 16 Oct, 10:18 PM Test Summary: 56612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15704

  113. Benni Mack uploaded patch set 55 10/17/17, 10:50

  114. TYPO3com voted on patch set 55 V +1 10/17/17, 10:59 Completed build in 08m 42s on Tue, 17 Oct, 12:59 PM Test Summary: 56612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15714

  115. Benni Mack uploaded patch set 56 10/17/17, 13:08

  116. TYPO3com voted on patch set 56 V +1 10/17/17, 13:17 Completed build in 09m 08s on Tue, 17 Oct, 03:17 PM Test Summary: 56612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15718

  117. Christian Kuhn uploaded patch set 57 10/17/17, 16:46

  118. TYPO3com voted on patch set 57 V -1 10/17/17, 16:56 Completed build in 09m 10s on Tue, 17 Oct, 06:56 PM Test Summary: 2 of 57055 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15730

  119. Christian Kuhn uploaded patch set 58 10/17/17, 18:45

  120. TYPO3com voted on patch set 58 V +1 10/17/17, 18:55 Completed build in 10m 20s on Tue, 17 Oct, 08:55 PM Test Summary: 56696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15734

  121. Benni Mack uploaded patch set 59 10/17/17, 20:15

  122. Christian Kuhn uploaded patch set 60 10/17/17, 20:17

  123. TYPO3com voted on patch set 59 V -1 10/17/17, 20:26 Completed build in 10m 27s on Tue, 17 Oct, 10:26 PM Test Summary: 14 of 57073 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15736

  124. TYPO3com voted on patch set 60 V -1 10/17/17, 20:28 Completed build in 10m 52s on Tue, 17 Oct, 10:28 PM Test Summary: 14 of 57073 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15737

  125. Benni Mack uploaded patch set 61 10/17/17, 20:43

  126. TYPO3com voted on patch set 61 V -1 10/17/17, 20:56 Completed build in 12m 52s on Tue, 17 Oct, 10:56 PM Test Summary: 6 of 57073 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15739

  127. Benni Mack uploaded patch set 62 10/17/17, 21:19

  128. TYPO3com voted on patch set 62 V -1 10/17/17, 21:29 Completed build in 09m 34s on Tue, 17 Oct, 11:29 PM Test Summary: 4 of 57073 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15743

  129. Benni Mack uploaded patch set 63 10/17/17, 23:03

  130. TYPO3com voted on patch set 63 V +1 10/17/17, 23:12 Completed build in 09m 36s on Wed, 18 Oct, 01:12 AM Test Summary: 56774 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15749

  131. Benni Mack commented on patch set 63 10/17/17, 23:40

    TranslationConfigurationProvider.php:193

    deprecation RST missing

    TranslationConfigurationProvider.php:206

    deprecation RST missing

    TranslationConfigurationProvider.php:221

    deprecation RST missing

    BackendUtility.php:551

    deprecation RST missing

    TcaMigration.php:970

    should be documented in deprecation RST

    Important-82445-MigratePagesLanguageOverlayIntoPages.rst:38

    one space too much to make it bold

    AbstractActionTestCase.php:470

    can be moved to irre_tutorial/Configuration/TCA/Overrides/pages.php

    ext_tables.sql:164

    should be renamed to "legacy_overlay_uid"
  132. Christian Kuhn commented on patch set 63 10/19/17, 18:54

    AbstractActionTestCase.php:470 Reply

    no, i think that does not work since other tests rely on this field not being set.
  133. Christian Kuhn uploaded patch set 64 10/19/17, 18:55

  134. TYPO3com voted on patch set 64 V -1 10/19/17, 19:06 Completed build in 10m 48s on Thu, 19 Oct, 09:06 PM Test Summary: 2 of 57133 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15799

  135. TYPO3com voted on patch set 64 V +1 10/19/17, 20:03 Completed build in 1h 18m 43s on Thu, 19 Oct, 10:03 PM Test Summary: 56774 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15799

  136. Christian Kuhn uploaded patch set 65 10/20/17, 13:28

  137. Christian Kuhn commented on patch set 65 10/20/17, 13:32

    just rebased.
  138. TYPO3com voted on patch set 65 V +1 10/20/17, 13:39 Completed build in 10m 13s on Fri, 20 Oct, 03:39 PM Test Summary: 56852 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15833

  139. Frank Nägler commented on patch set 65 10/26/17, 13:45

    I guess one acceptance will break, maybe someone can run the acceptance test with this PR? My tests does not run locally. big thanks to, this PR is awesome, I am really happy to see this table gone...
  140. Georg Ringer uploaded patch set 66 10/26/17, 13:59

  141. TYPO3com voted on patch set 66 V -1 10/26/17, 14:10 Completed build in 10m 42s on Thu, 26 Oct, 04:10 PM Test Summary: 2 of 57211 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15874

  142. TYPO3com voted on patch set 66 V +1 10/26/17, 14:15 Completed build in 26m 45s on Thu, 26 Oct, 04:15 PM Test Summary: 56852 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15874

  143. Frank Nägler voted on patch set 66 CR +1 10/26/17, 14:49

  144. Nicole Hummel commented on patch set 66 10/28/17, 18:06

    TranslationConfigurationProvider.php:142

    Can we really remove this exception? I'm unsure but doesn't the pid of pages means something other than the pid of records.

    TranslationConfigurationProvider.php:222

    IMHO this needs to return pages to still get the correct translation table. pages_language_overlay doesn't exists anymore, does it?

    FormDataCompiler.php:159

    are + missing )

    BackendUtility.php:3694

    Removing the exception for tables changes return value. Was this intended?
  145. Benni Mack commented on patch set 66 10/29/17, 11:21

    TranslationConfigurationProvider.php:142 Reply

    This is actually correct.The PID of the default page is the same as the PID of the translation. This was different when having "pages_language_overlay" in use. This method is used in ListModule (translation work here) and in FormEngine to render the dropdown of alternative languages - will check this again however just to be sure.

    TranslationConfigurationProvider.php:222 Reply

    TCA and DB table still are kept for v9 to ensure compatibility with extensions extending pages / pages_language_overlay with fields. However, this method is obsolete, and with the new mapping, should return '' all the time, right? the method comment states "if any", and with pages there isn't "any" anymore.

    FormDataCompiler.php:159 Reply

    will fix this

    BackendUtility.php:3694 Reply

    Used in "List module", Page module (only for tt_content) and Context Menu to count the available translations (to show a message). Basically, it could be seen as a new feature, as this message now can count translations for pages as well. We have several cases, also within DataHandler where methods (moveTranslations() or deleteTranslations()) now can deal with pages as well. Should we add this to the FeatureRST? Or rather Breaking RST? I'd opt for the first one...
  146. Benni Mack uploaded patch set 67 10/30/17, 12:42

  147. TYPO3com voted on patch set 67 V -1 10/30/17, 12:52 Completed build in 09m 39s on Mon, 30 Oct, 01:52 PM Test Summary: 10 of 57211 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15914

  148. TYPO3com commented on patch set 67 10/30/17, 13:28 Completed build in 55m 56s on Mon, 30 Oct, 02:28 PM Test Summary: 8 of 57211 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15914

  149. Benni Mack uploaded patch set 68 10/30/17, 14:13

  150. TYPO3com voted on patch set 68 V -1 10/30/17, 14:22 Completed build in 09m 11s on Mon, 30 Oct, 03:22 PM Test Summary: 2 of 57211 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15915

  151. Benni Mack uploaded patch set 69 10/30/17, 15:56

  152. TYPO3com voted on patch set 69 V -1 10/30/17, 16:05 Completed build in 09m 25s on Mon, 30 Oct, 05:05 PM Test Summary: 2 of 57211 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15917

  153. TYPO3com voted on patch set 69 V +1 10/30/17, 16:26 Completed build in 39m 30s on Mon, 30 Oct, 05:26 PM Test Summary: 56852 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15917

  154. Benni Mack uploaded patch set 70 10/30/17, 17:10

  155. TYPO3com voted on patch set 70 V -1 10/30/17, 17:12 Completed build in 02m 17s on Mon, 30 Oct, 06:12 PM Test Summary: 2670 of 57139 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15920

  156. Tymoteusz Motylewski commented on patch set 70 10/31/17, 09:41

    I would be interested in seeing the comparison between how core handles tree structure (with translations) for pages and for categories. If possible, I would love to see similar approach/rules being used in both cases.
  157. TYPO3com commented on patch set 70 10/31/17, 09:45 Completed build in 16h 36m 46s on Tue, 31 Oct, 10:45 AM Test Summary: 2670 of 57139 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15920

  158. TYPO3com commented on patch set 70 10/31/17, 09:57 Completed build in 9h 23m 38s on Tue, 31 Oct, 10:57 AM Test Summary: 2670 of 57139 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15920

  159. Christian Kuhn commented on patch set 70 11/01/17, 10:34

    pages_language_overlay.php:4

    that won't work since db connection isn't always initialized when reading TCA (and having db shouldn't be a dependency for TCA loading anyways).
  160. Christian Kuhn uploaded patch set 71 11/01/17, 10:34

  161. Christian Kuhn commented on patch set 71 11/01/17, 10:35

    repushed set 69 as set 71 - effectively removing the 'check wizard done' in TCA code again.
  162. Nicole Hummel commented on patch set 70 11/01/17, 10:42

    pages_language_overlay.php:4 Reply

    This was introduced to prevent the TCA from being included after migration. Is there any chance to load this in Install Tool context only?
  163. TYPO3com voted on patch set 71 V +1 11/01/17, 10:45 Completed build in 10m 18s on Wed, 1 Nov, 11:45 AM Test Summary: 56954 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15953

  164. Benni Mack commented on patch set 70 11/02/17, 09:07

    pages_language_overlay.php:4 Reply

    I will look into the possibility of having real "Feature Flags" for the core so we could use this functionality to prevent loading of TCA once the migration is done.
  165. Benni Mack uploaded patch set 72 11/02/17, 11:04

  166. TYPO3com voted on patch set 72 V -1 11/02/17, 11:13 Completed build in 08m 54s on Thu, 2 Nov, 12:13 PM Test Summary: 454 of 57307 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15984

  167. TYPO3com commented on patch set 72 11/02/17, 11:27 Completed build in 31m 54s on Thu, 2 Nov, 12:27 PM Test Summary: 454 of 57307 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15984

  168. Benni Mack uploaded patch set 73 11/02/17, 11:29

  169. TYPO3com voted on patch set 73 V -1 11/02/17, 11:38 Completed build in 08m 45s on Thu, 2 Nov, 12:38 PM Test Summary: 17 of 57307 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15988

  170. TYPO3com commented on patch set 73 11/02/17, 11:42 Completed build in 21m 38s on Thu, 2 Nov, 12:42 PM Test Summary: 15 of 57307 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15988

  171. Benni Mack uploaded patch set 74 11/02/17, 15:14

  172. TYPO3com voted on patch set 74 V +1 11/02/17, 15:26 Completed build in 11m 07s on Thu, 2 Nov, 04:26 PM Test Summary: 56948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15996

  173. Benni Mack uploaded patch set 75 11/02/17, 15:47

  174. TYPO3com voted on patch set 75 V +1 11/02/17, 15:57 Completed build in 10m 26s on Thu, 2 Nov, 04:57 PM Test Summary: 56912 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16002

  175. Christian Kuhn voted on patch set 75 CR +1 V +1 11/03/17, 13:34

  176. Frans Saris commented on patch set 75 11/03/17, 13:55

    DataHandler.php:1044

    Shouldn't this not also be $incomingFieldArray['l10n_parent'] for translations?
  177. Benni Mack commented on patch set 75 11/03/17, 14:05

    DataHandler.php:1044 Reply

    thanks for looking into it, I actually checked that (because the change on this area was really difficult). This is necessary because we check against the PID of the default page, if this does not exist, it is not possible to do anything. There is also a slight difference between $fieldArray and $incomingFieldArray.
  178. Benni Mack commented on patch set 75 CR -1 11/04/17, 10:56

    -1: l10n_state writes "Array" in the DB -1: moving a page throws an error
  179. Andreas Kienast uploaded patch set 76 11/04/17, 13:56

  180. Andreas Kienast uploaded patch set 77 11/04/17, 14:01

  181. TYPO3com voted on patch set 76 V +1 11/04/17, 14:06 Completed build in 09m 54s on Sat, 4 Nov, 03:06 PM Test Summary: 56768 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16071

  182. Oliver Hader commented on patch set 77 11/04/17, 14:10

    DataMapProcessor.php:165

    Good catch!
  183. TYPO3com voted on patch set 77 V -1 11/04/17, 14:11 Completed build in 09m 29s on Sat, 4 Nov, 03:11 PM Test Summary: 2 of 57127 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16072

  184. Oliver Hader commented on patch set 77 11/04/17, 14:11

    So: The issue having "Array" in l10n_state is solved now
  185. TYPO3com voted on patch set 77 V +1 11/04/17, 14:12 Completed build in 20m 25s on Sat, 4 Nov, 03:12 PM Test Summary: 56768 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16072

  186. Benni Mack commented on patch set 77 11/04/17, 15:28

    Thanks, now it's all looking good!
  187. Andreas Kienast voted on patch set 77 CR +1 V +1 11/04/17, 16:11

  188. Frans Saris commented on patch set 77 V -1 11/04/17, 16:58

    When you copy a page in de page tree (drag&drop) I get the error Exception [1.1.-1]: Attempt to insert record "pages_language_overlay:10" on a page (46) that can't store record type.
  189. Oliver Hader commented on patch set 77 V -1 11/04/17, 17:00

    Argument 3 passed to TYPO3\CMS\Core\DataHandling\Localization\DataMapProcessor::synchronizeFieldValues() must be of the type array, null given, called in /Users/olly/Development/typo3/master/typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php on line 311 - for "no_search" // will check that
  190. Frans Saris commented on patch set 77 11/04/17, 17:12

    DatabaseRecordList.php:3194

    Shouldn't this be changed to?
  191. Oliver Hader uploaded patch set 78 11/04/17, 17:43

  192. Oliver Hader commented on patch set 78 CR -1 V -1 11/04/17, 17:44

    Still missing: * load TCA without running TCA-migrations when executing the upgrade wizard * analyse bug when copying pages
  193. TYPO3com voted on patch set 78 V -1 11/04/17, 17:53 Completed build in 09m 54s on Sat, 4 Nov, 06:53 PM Test Summary: 26 of 57127 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16076

  194. Benni Mack uploaded patch set 79 11/05/17, 15:03

  195. TYPO3com voted on patch set 79 V +1 11/05/17, 15:13 Completed build in 09m 46s on Sun, 5 Nov, 04:13 PM Test Summary: 56768 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16089

  196. Stefan Froemken commented on patch set 79 11/05/17, 21:39

    You don't have consistent conditions to check for a translated pages record. Sometimes you use sys_language_uid > 0, sometime l10n_parent > 0, sometime both variants and sometimes "l10n_parent ?? uid". Can you please decide for one solution or create a little pageHasTranslation function to solve that?
  197. Stefan Froemken commented on patch set 79 11/05/17, 21:59

    AbstractDatabaseRecordList.php:807

    please check, if we can do the same in row 3194, too.
  198. Benni Mack commented on patch set 79 11/06/17, 11:19

    AbstractDatabaseRecordList.php:807 Reply

    this class does not have 3194 lines...
  199. Benni Mack uploaded patch set 80 11/06/17, 11:19

  200. TYPO3com voted on patch set 80 V -1 11/06/17, 11:20 Completed build in 08s on Mon, 6 Nov, 12:20 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16109

  201. Christian Kuhn uploaded patch set 81 11/06/17, 11:29

  202. TYPO3com voted on patch set 81 V -1 11/06/17, 11:44 Completed build in 15m 12s on Mon, 6 Nov, 12:44 PM Test Summary: 2 of 57127 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16110

  203. TYPO3com voted on patch set 81 V +1 11/06/17, 11:49 Completed build in 35m 15s on Mon, 6 Nov, 12:49 PM Test Summary: 56768 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16110

  204. Christian Kuhn voted on patch set 81 CR +1 V +1 11/06/17, 13:10

  205. Christian Kuhn uploaded patch set 82 11/06/17, 18:54

  206. Christian Kuhn voted on patch set 82 CR +1 V +1 11/06/17, 18:54

  207. TYPO3com voted on patch set 82 V -1 11/06/17, 19:05 Completed build in 10m 43s on Mon, 6 Nov, 08:05 PM Test Summary: 2 of 57127 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16129

  208. TYPO3com voted on patch set 82 V +1 11/06/17, 19:17 Completed build in 33m 35s on Mon, 6 Nov, 08:17 PM Test Summary: 56768 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16129

  209. Frank Nägler voted on patch set 82 CR +1 V +1 11/06/17, 21:17

  210. Tymoteusz Motylewski commented on patch set 82 11/06/17, 22:14

    DatabaseDefaultLanguagePageRow.php:2

    don't we need strict here?

    DatabaseDefaultLanguagePageRowTest.php:2

    don't we need strict here?
  211. Benni Mack commented on patch set 83 11/07/17, 06:07

    Published edit on patch set 82.
  212. Benni Mack commented on patch set 83 11/07/17, 06:08

    thanks, added that!
  213. TYPO3com voted on patch set 83 V +1 11/07/17, 06:17 Completed build in 09m 35s on Tue, 7 Nov, 07:17 AM Test Summary: 56768 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16139

  214. Stefan Froemken commented on patch set 83 11/07/17, 06:55

    DatabaseRecordList.php:3195

    I meen that one here
  215. Benni Mack commented on patch set 84 11/07/17, 07:00

    Published edit on patch set 83.
  1. Benni Mack commented on patch set 84 11/07/17, 07:01

    Thanks Stefan, fixed (I moved the code into the followup patch for the list view, which removes that line)
  2. TYPO3com voted on patch set 84 V +1 11/07/17, 07:10 Completed build in 09m 23s on Tue, 7 Nov, 08:10 AM Test Summary: 56768 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16142

  3. Christian Kuhn voted on patch set 84 CR +1 V +1 11/07/17, 12:50

  4. Frans Saris voted on patch set 84 CR +1 11/07/17, 14:39

  5. Andreas Kienast uploaded patch set 85 11/08/17, 05:50

  6. TYPO3com voted on patch set 85 V +1 11/08/17, 06:00 Completed build in 09m 58s on Wed, 8 Nov, 07:00 AM Test Summary: 56768 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16169

  7. Frans Saris commented on patch set 85 11/08/17, 06:20

    Last patch set was only a rebase?
  8. Andreas Kienast commented on patch set 85 11/08/17, 06:35

    Yes, and now we need another one ;)
  9. Benni Mack uploaded patch set 86 11/08/17, 06:35

  10. Benni Mack commented on patch set 86 11/08/17, 06:43

    just rebases, as there are further merges happening.
  11. TYPO3com voted on patch set 86 V -1 11/08/17, 06:47 Completed build in 11m 29s on Wed, 8 Nov, 07:47 AM Test Summary: 56768 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16171

  12. TYPO3com voted on patch set 86 V +1 11/08/17, 07:52 Completed build in 1h 28m 06s on Wed, 8 Nov, 08:52 AM Test Summary: 56768 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16171

  13. Frank Nägler voted on patch set 86 CR +1 V +1 11/08/17, 07:53

  14. Andreas Kienast uploaded patch set 87 11/08/17, 09:37

  15. Andreas Kienast commented on patch set 87 11/08/17, 09:37

    Rebased only
  16. TYPO3com voted on patch set 87 V +1 11/08/17, 09:48 Completed build in 10m 49s on Wed, 8 Nov, 10:48 AM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16174

  17. Frans Saris voted on patch set 87 CR +1 V +1 11/08/17, 10:03

  18. Andreas Kienast voted on patch set 87 CR +1 11/08/17, 10:24

  19. Christian Kuhn voted on patch set 87 CR +1 V +1 11/08/17, 10:47

  20. Frank Nägler voted on patch set 87 CR +1 V +1 11/08/17, 10:51

  21. Andreas Kienast voted on patch set 87 CR +2 V +2 11/08/17, 10:53

  22. Gerrit merged patch set 87 11/08/17, 10:55

  23. Nicole Hummel commented on patch set 88 11/12/17, 18:05

    Due to my review I've seen multiple hardcoded field names. I'm not sure if this is should be cleaned up in another patch set to retrieve field configuration from TCA. Furthermore I tested the current master with a fresh installation and the current released TER version of bootstrap_package/introduction_package. I know there are some pages_language_overlay records inside the shipped t3d file. After installing the distribution I had nor translated page. I would expect to either have pages_language_overlay records (that can be moved with the upgrade wizard later) or handle the import/export the movement from pages_language_overlay to pages. Is this something we are aware of? Do I have wrong expectations?

    PageLayoutController.php:330

    Maybe we should replace that hard-coded field name with the one defined in TCA?

    DatabaseDefaultLanguagePageRow.php:35

    IMHO $tableName is not needed here as we can use 'pages' all the time and do an early return if $result['tableName'] !== 'pages'

    DatabasePageLanguageOverlayRows.php:63

    Retrieve field from TCA?

    AbstractRecordList.php:462

    Retrieve field from TCA?

    AbstractRecordList.php:463

    Retrieve field from TCA?

    AbstractRecordList.php:470

    Retrieve field from TCA?

    DataProvider.php:449

    Retrieve field from TCA?
  24. Benni Mack commented on patch set 88 11/14/17, 07:11

    Thanks for the post-review, will do a cleanup of the hardcoded field names in the next few days. For the "compatibility" from introduction package / import/export, I will also create another patch.
  25. Markus Klein commented on patch set 88 06/06/19, 16:00

    pages.php:357 Unresolved

    Does not make sense for a checkbox.

    pages.php:581 Unresolved

    Does not make sense for group field