Review main Merged

51305[BUGFIX] Truncate long GIFBUILDER file names

Thomas Oliver Moll CR +2 V +2 Easy +3 −0 updated 02/14/17, 15:38

Commit message

GIFBUILDER generates file names from serialized data from
the GIFBUILDER setup (typoscript).
This can result in too long file names when the GIFBUILDER
is called with many parameters and on filesystems with
a max filename/path length.

The comment of the function fileName() states that the filename
should be shortened to 100 chars, but this doesn't happen.

This patch introduces a simple substring to enforce this limit.

Review

  • Code review CR +2
    • Markus Klein +2
    • Marco Huber +1
    • Benni Mack +1
  • Verified V +2
    • Markus Klein +2
    • Marco Huber +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1621

  1. Thomas Oliver Moll uploaded patch set 1 01/13/17, 14:19

  2. TYPO3com voted on patch set 1 V -1 01/13/17, 14:25 Completed build in 05m 16s on Fri, 13 Jan, 03:25 PM Test Summary: 54939 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6621

  3. Markus Klein commented on patch set 1 01/13/17, 14:34

    Please use real names for author of the commit. I'll push a new version setting your name there.
  4. Markus Klein uploaded patch set 2 01/13/17, 14:38

  5. Markus Klein uploaded patch set 3 01/13/17, 14:42

  6. Markus Klein uploaded patch set 4 01/13/17, 14:43

  7. TYPO3com voted on patch set 2 V -1 01/13/17, 14:43 Completed build in 04m 37s on Fri, 13 Jan, 03:43 PM Test Summary: 54939 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6624

  8. Markus Klein commented on patch set 4 CR +1 V +1 01/13/17, 14:43

    CI should be happy now too. Thanks for the patch
  9. TYPO3com voted on patch set 3 V -1 01/13/17, 14:47 Completed build in 05m 00s on Fri, 13 Jan, 03:47 PM Test Summary: 54939 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6625

  10. TYPO3com voted on patch set 4 V +1 01/13/17, 14:48 Completed build in 05m 40s on Fri, 13 Jan, 03:48 PM Test Summary: 54939 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6626

  11. Marco Huber voted on patch set 4 CR +1 V +1 02/14/17, 12:15

  12. Marco Huber rebased onto patch set 5 02/14/17, 12:44

  13. Marco Huber commented on patch set 5 CR +1 V +1 02/14/17, 12:49

    Sorry, I forgot to reset my master branch to origin/master for another patch and accidently updated this one...
  14. TYPO3com voted on patch set 5 V +1 02/14/17, 12:50 Completed build in 06m 23s on Tue, 14 Feb, 01:50 PM Test Summary: 56275 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8043

  15. Benni Mack commented on patch set 5 CR -1 02/14/17, 14:04

    yeah, I removed that option to limit this - but substr() seems like a bad idea tbh. just shorten it to substr($fileName) + a GeneralUtility::shortMd5($fileName)
  16. Markus Klein commented on patch set 5 02/14/17, 14:31

    @Benni: no need for that. the final filename has a hash already.
  17. Benni Mack commented on patch set 5 CR +1 02/14/17, 14:32

    OK. then no problem from my side.
  18. Markus Klein voted on patch set 5 CR +1 V +1 02/14/17, 14:32

  19. Markus Klein commented on patch set 5 CR +2 V +2 02/14/17, 15:38

    thx benni
  20. Gerrit merged patch set 5 02/14/17, 15:38

  21. Markus Klein commented on patch set 6 02/14/17, 15:38

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit df1489b012db96650f020d7f8112cd9b46e01549