Review main Merged

51309[TASK] Deprecate ArrayUtility::inArray()

Wouter Wolters CR +2 V +2 Easy +39 −7 updated 01/17/17, 15:33

Commit message

Review

  • Code review CR +2
    • Georg Ringer +2
    • Mona Muzaffar +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1115

  1. Wouter Wolters uploaded patch set 1 01/13/17, 16:10

  2. Wouter Wolters uploaded patch set 2 01/13/17, 16:12

  3. TYPO3com voted on patch set 1 V -1 01/13/17, 16:15 Completed build in 05m 15s on Fri, 13 Jan, 05:15 PM Test Summary: 54939 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6630

  4. TYPO3com voted on patch set 2 V -1 01/13/17, 16:17 Completed build in 04m 58s on Fri, 13 Jan, 05:17 PM Test Summary: 54939 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6631

  5. Wouter Wolters uploaded patch set 3 01/13/17, 16:23

  6. TYPO3com voted on patch set 3 V +1 01/13/17, 16:28 Completed build in 04m 34s on Fri, 13 Jan, 05:28 PM Test Summary: 54939 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6632

  7. Tymoteusz Motylewski commented on patch set 3 01/13/17, 17:53

    ArrayUtility.php:655

    According to the comment above, this method has different behaviour than in_array. Is there a migration path for "variant_a" ?
  8. Benni Mack commented on patch set 3 01/15/17, 11:27

    ArrayUtility.php:655 Reply

    yes. the preferred way is actually to use in_array() with the third parameter set to true. this means, the developer should convert his/her type fo the needle and the array correctly. Which leads to less side effects in the code.
  9. Mathias Brodala commented on patch set 4 01/16/17, 08:22

    Published edit on patch set 3.
  10. Benni Mack voted on patch set 4 CR +1 V +1 01/16/17, 08:23

  11. TYPO3com voted on patch set 4 V +1 01/16/17, 08:26 Completed build in 04m 00s on Mon, 16 Jan, 09:26 AM Test Summary: 54939 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6679

  12. Mona Muzaffar voted on patch set 4 CR +1 01/17/17, 10:59

  13. Andreas Kienast voted on patch set 4 CR +1 01/17/17, 14:04

  14. Georg Ringer voted on patch set 4 CR +2 V +2 01/17/17, 15:33

  15. Gerrit merged patch set 4 01/17/17, 15:33