51324[FEATURE] Add useCacheHash to typolink viewhelpers
Commit message
Review
-
Code review CR +2
- Frans Saris +2
- Tymoteusz Motylewski +1
- Mona Muzaffar +1
- Jörg Bösche +1
-
Verified V +2
- Frans Saris +2
- Mona Muzaffar +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1718
-
anonymized-50850 uploaded patch set 1 01/16/17, 12:43
-
TYPO3com voted on patch set 1 V +1 01/16/17, 12:48 Completed build in 04m 12s on Mon, 16 Jan, 01:48 PM Test Summary: 54939 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6687
-
Frans Saris commented on patch set 1 01/16/17, 12:53
-
anonymized-50850 commented on patch set 1 01/16/17, 13:08
@Frans: cannot reply to your comment. Seems like I'm in draft mode only. Regarding your concern: Nope. If it was, I wouldn't have stumbled opon this issue ;-) -
Andreas Kienast commented on patch set 1 01/16/17, 13:38
TypolinkViewHelper.php:77ReplyFor typolinks, useCacheHash is false by default. -
Andreas Kienast commented on patch set 1 CR -1 01/16/17, 13:39
Please add a RST document describing the feature. You may use https://forger.typo3.org/utility/rst for assistance :-) -
Andreas Kienast commented on patch set 1 CR 0 01/16/17, 13:45
Sorry, never mind, I'll grab another coffee... -
Mona Muzaffar voted on patch set 1 V +1 01/17/17, 09:57
-
Mona Muzaffar commented on patch set 1 V 0 01/17/17, 10:13
I am not very familiar with viewhelper settings, but is it normal that when you put useCacheHash to false it still generates a cHash, so it only checks whether it is set or not? -
Mona Muzaffar voted on patch set 1 V +1 01/17/17, 10:13
-
Mona Muzaffar voted on patch set 1 CR +1 01/25/17, 14:43
-
Jörg Bösche voted on patch set 1 CR +1 01/26/17, 07:27
-
Tymoteusz Motylewski voted on patch set 1 CR +1 02/06/17, 15:24
-
Frans Saris voted on patch set 1 CR +1 V +1 02/07/17, 18:52
-
Frans Saris voted on patch set 1 CR +2 V +2 02/07/17, 18:52
-
Gerrit merged patch set 1 02/07/17, 18:52
-
Mathias Schreiber commented on patch set 2 02/12/17, 10:49
Can some please explain to me what the documentation RST is about? It says absolutely nothing about what changed. -
Frans Saris commented on patch set 2 02/12/17, 11:23
Oeps. Description: The useChache parameter is added to the typoscript Viewhelpers. Impact: There is no impact for existing installations.
TypolinkViewHelper.php:77