Review main Merged

51324[FEATURE] Add useCacheHash to typolink viewhelpers

anonymized-50850 CR +2 V +2 Easy +22 −2 updated 02/12/17, 11:23

Commit message

Review

  • Code review CR +2
    • Frans Saris +2
    • Tymoteusz Motylewski +1
    • Mona Muzaffar +1
    • Jörg Bösche +1
  • Verified V +2
    • Frans Saris +2
    • Mona Muzaffar +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1718

  1. anonymized-50850 uploaded patch set 1 01/16/17, 12:43

  2. TYPO3com voted on patch set 1 V +1 01/16/17, 12:48 Completed build in 04m 12s on Mon, 16 Jan, 01:48 PM Test Summary: 54939 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6687

  3. Frans Saris commented on patch set 1 01/16/17, 12:53

    TypolinkViewHelper.php:77

    Isn't the default behavior true?
  4. anonymized-50850 commented on patch set 1 01/16/17, 13:08

    @Frans: cannot reply to your comment. Seems like I'm in draft mode only. Regarding your concern: Nope. If it was, I wouldn't have stumbled opon this issue ;-)
  5. Andreas Kienast commented on patch set 1 01/16/17, 13:38

    TypolinkViewHelper.php:77 Reply

    For typolinks, useCacheHash is false by default.
  6. Andreas Kienast commented on patch set 1 CR -1 01/16/17, 13:39

    Please add a RST document describing the feature. You may use https://forger.typo3.org/utility/rst for assistance :-)
  7. Andreas Kienast commented on patch set 1 CR 0 01/16/17, 13:45

    Sorry, never mind, I'll grab another coffee...
  8. Mona Muzaffar voted on patch set 1 V +1 01/17/17, 09:57

  9. Mona Muzaffar commented on patch set 1 V 0 01/17/17, 10:13

    I am not very familiar with viewhelper settings, but is it normal that when you put useCacheHash to false it still generates a cHash, so it only checks whether it is set or not?
  10. Mona Muzaffar voted on patch set 1 V +1 01/17/17, 10:13

  11. Mona Muzaffar voted on patch set 1 CR +1 01/25/17, 14:43

  12. Jörg Bösche voted on patch set 1 CR +1 01/26/17, 07:27

  13. Tymoteusz Motylewski voted on patch set 1 CR +1 02/06/17, 15:24

  14. Frans Saris voted on patch set 1 CR +1 V +1 02/07/17, 18:52

  15. Frans Saris voted on patch set 1 CR +2 V +2 02/07/17, 18:52

  16. Gerrit merged patch set 1 02/07/17, 18:52

  17. Mathias Schreiber commented on patch set 2 02/12/17, 10:49

    Can some please explain to me what the documentation RST is about? It says absolutely nothing about what changed.
  18. Frans Saris commented on patch set 2 02/12/17, 11:23

    Oeps. Description: The useChache parameter is added to the typoscript Viewhelpers. Impact: There is no impact for existing installations.