Review main Merged

51332[TASK] Use runtime cache for BackendUtility::isRecordLocked

Georg Ringer CR +2 V +2 Easy +15 −9 updated 11/22/17, 23:40

Commit message

Instead of using $GLOBALS a runtime cache is used.

Review

  • Code review CR +2
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2
    • Markus Klein +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1013

  1. Georg Ringer uploaded patch set 1 01/17/17, 06:51

  2. TYPO3com voted on patch set 1 V +1 01/17/17, 06:54 Completed build in 03m 51s on Tue, 17 Jan, 07:54 AM Test Summary: 54939 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6719

  3. Andreas Kienast commented on patch set 1 01/17/17, 08:13

    No extension in the TER uses LOCKED_RECORDS, but I'm still not sure if this is a "real" breaking change.
  4. Georg Ringer updated the commit message in patch set 2 01/17/17, 09:03

  5. Georg Ringer commented on patch set 2 01/17/17, 09:03

    i can add a breaking rst for that if wanted.
  6. TYPO3com voted on patch set 2 V +1 01/17/17, 09:07 Completed build in 04m 03s on Tue, 17 Jan, 10:07 AM Test Summary: 54969 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6726

  7. Benni Mack uploaded patch set 3 01/17/17, 09:46

  8. TYPO3com voted on patch set 3 V +1 01/17/17, 09:51 Completed build in 05m 17s on Tue, 17 Jan, 10:51 AM Test Summary: 54969 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6729

  9. Markus Klein voted on patch set 3 CR +1 01/18/17, 10:05

  10. Benni Mack voted on patch set 3 CR +2 V +1 01/18/17, 10:19

  11. Markus Klein voted on patch set 3 V +2 01/18/17, 11:58

  12. Gerrit merged patch set 3 01/18/17, 11:58

  13. Markus Klein commented on patch set 4 11/22/17, 23:40

    BackendUtility.php:3751

    this is wrong and is fixed with https://review.typo3.org/54726