Review main Abandoned

51339[WIP][BUGFIX] PagePositionMap: add visual indent for new subpage

Josef Glatz CR 0 V 0 Easy +25 −23 updated 02/05/18, 19:07

Commit message

Readd a visual indent for links, which add a page as
a subpage of the parent selected page.

Also some cleanup:
* method calls where too many parameters were used
* import classes with use statements
* move initial variable assignment before the if in `insertPositionIcon()`

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 56

  1. Josef Glatz uploaded patch set 1 01/18/17, 08:35

  2. Josef Glatz commented on patch set 1 CR -1 V -1 01/18/17, 08:37

    Actually, the fix needs to be fixed to also work if you open the new page action on a sub-sub-page, on it
  3. TYPO3com voted on patch set 1 V +1 01/18/17, 08:40 Completed build in 04m 54s on Wed, 18 Jan, 09:40 AM Test Summary: 54981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6756

  4. Josef Glatz voted on patch set 1 V 0 01/18/17, 08:51

  5. Benni Mack commented on patch set 1 11/24/17, 21:08

    ping, can you continue here?
  6. Benni Mack abandoned the change 02/05/18, 19:07

    No feedback in the last 12 months, abandoning now (can be restored later if somebody wants to pick it up)