51342[BUGFIX] Access check for delete pages expects array of integers
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Anja Leichsenring +1
-
Verified V +2
- Christian Kuhn +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1316
-
Mona Muzaffar uploaded patch set 1 01/18/17, 14:10
-
TYPO3com voted on patch set 1 V -1 01/18/17, 14:16 Completed build in 05m 05s on Wed, 18 Jan, 03:16 PM Test Summary: 54981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6772
-
Mona Muzaffar uploaded patch set 2 01/18/17, 14:28
-
TYPO3com voted on patch set 2 V +1 01/18/17, 14:32 Completed build in 04m 07s on Wed, 18 Jan, 03:32 PM Test Summary: 54981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6775
-
Anja Leichsenring voted on patch set 2 CR +1 V +1 01/26/17, 08:05
-
Wouter Wolters commented on patch set 2 01/26/17, 08:07
remove extra space herewhy 7.6? This is about createNamedParameter which is from Doctrine. -
Benni Mack commented on patch set 2 01/26/17, 08:08
DataHandler.php:8069then this should check for is(!empty($pids)) right? -
Anja Leichsenring commented on patch set 2 CR 0 V 0 01/26/17, 08:11
Wouter is right, no backport please. But Benni, the parameter is never empty, it comes from two calling points which at least pass a valid uid in. Empty check is therefor not necessary. -
Mona Muzaffar uploaded patch set 3 01/26/17, 08:36
-
TYPO3com voted on patch set 3 V +1 01/26/17, 08:41 Completed build in 04m 54s on Thu, 26 Jan, 09:41 AM Test Summary: 55149 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7049
-
Christian Kuhn commented on patch set 3 CR +1 V +1 01/26/17, 12:03
pretty easy to test ... -
Anja Leichsenring voted on patch set 3 CR +1 V +1 01/26/17, 12:06
-
Christian Kuhn voted on patch set 3 CR +2 V +2 01/26/17, 12:08
-
Gerrit merged patch set 3 01/26/17, 12:09
-
Stephan Großberndt commented on patch set 4 02/01/17, 10:50
Post -1DataHandler.php:8080What is the sense of using rmComma() on a string which by the check before cannot contain a comma? The rmComma() function is only used here. Remove usage and deprecate it?DataHandler.php:8081$inList must be casted to int here and should be checked if its empty too. Even if $inList just contains a single int, it still can be parsed without problems by GeneralUtility::intExplode. Is the overhead worth the switch?DataHandler.php:8083Working on $inList now to create the array $pids and then checking $inList afterwards (which now even isn't trimmed anymore in case it contains a comma) does not make sense. Instead check for an empty $pids array. -
Stephan Großberndt commented on patch set 4 02/01/17, 13:08
I added a kind of followup to this patch: https://review.typo3.org/#/c/51497/