Review main Merged

51349[TASK] Cleanup code of LocalizationController::process

Manuel Selbach CR +2 V +2 Easy +11 −14 updated 01/26/17, 07:57

Commit message

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Manuel Selbach +1
    • Christian Kuhn +1
    • Mona Muzaffar +1
    • Jörg Bösche +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1113

  1. Manuel Selbach uploaded patch set 1 01/18/17, 20:32

  2. TYPO3com voted on patch set 1 V +1 01/18/17, 20:36 Completed build in 04m 21s on Wed, 18 Jan, 09:36 PM Test Summary: 54981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6792

  3. Georg Ringer commented on patch set 1 CR +1 V +1 01/19/17, 05:15

    LocalizationController.php:235

    while being on it, you can remove that line as well
  4. Benni Mack commented on patch set 2 01/19/17, 07:41

    Published edit on patch set 1.
  5. TYPO3com voted on patch set 2 V +1 01/19/17, 07:45 Completed build in 04m 23s on Thu, 19 Jan, 08:45 AM Test Summary: 54981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6804

  6. Manuel Selbach voted on patch set 2 CR +1 01/19/17, 10:05

  7. Mona Muzaffar voted on patch set 2 CR +1 01/19/17, 12:41

  8. Wouter Wolters voted on patch set 2 CR +1 01/23/17, 09:26

  9. Christian Kuhn voted on patch set 2 CR +1 V +1 01/25/17, 23:43

  10. Jörg Bösche voted on patch set 2 CR +1 01/26/17, 07:24

  11. Anja Leichsenring voted on patch set 2 CR +2 V +2 01/26/17, 07:57

  12. Gerrit merged patch set 2 01/26/17, 07:57

  13. Anja Leichsenring commented on patch set 3 01/26/17, 07:57

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 1f3d35bc4a1cf6d73474bfe49af62472584fb728