Review main Merged

51351[TASK] Cleanup ActionService::getVersionedId

Manuel Selbach CR +2 V +2 Easy +1 −2 updated 01/25/17, 23:41

Commit message

Within the refactoring process the optional parameter $useDeleteClause was missed
to remove from the parameter list of the method, as it is not implemented in the body and
not used anywhere in the core.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Manuel Selbach uploaded patch set 1 01/18/17, 21:01

  2. TYPO3com voted on patch set 1 V +1 01/18/17, 21:06 Completed build in 05m 00s on Wed, 18 Jan, 10:06 PM Test Summary: 54981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6793

  3. Tymoteusz Motylewski commented on patch set 1 01/18/17, 21:34

    just a minor thing, please add an issue number like: Resolves: #1234
  4. Manuel Selbach updated the commit message in patch set 2 01/18/17, 21:45

  5. TYPO3com voted on patch set 2 V +1 01/18/17, 21:50 Completed build in 05m 09s on Wed, 18 Jan, 10:50 PM Test Summary: 54981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6801

  6. Wouter Wolters voted on patch set 2 CR +1 V +1 01/23/17, 09:27

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 01/25/17, 23:41

  8. Gerrit merged patch set 2 01/25/17, 23:41