Review main Merged

51360[BUGFIX] Extbase: Do not mangle SQL query when constraint value is empty

Markus Klein CR +2 V +2 Easy +13 −9 updated 01/19/17, 15:04

Commit message

The query parser now throws an exception if the given value for an
IN or CONTAINS expression is invalid, instead of silently converting
it to a "1<>1" condition.
This helps developers when searching for broken queries and prevents
running queries with invalid/useless constraints.

Review

  • Code review CR +2
    • Philipp Gampe +2
    • Johannes Kasberger +1
    • Wouter Wolters +1
  • Verified V +2
    • Philipp Gampe +2
    • Johannes Kasberger +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Markus Klein uploaded patch set 1 01/19/17, 12:54

  2. TYPO3com voted on patch set 1 V +1 01/19/17, 12:59 Completed build in 04m 23s on Thu, 19 Jan, 01:59 PM Test Summary: 54987 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6809

  3. Johannes Kasberger voted on patch set 1 CR +1 V +1 01/19/17, 13:03

  4. Wouter Wolters voted on patch set 1 CR +1 01/19/17, 13:05

  5. Philipp Gampe voted on patch set 1 CR +1 V +1 01/19/17, 13:37

  6. Philipp Gampe voted on patch set 1 CR +2 V +2 01/19/17, 13:38

  7. Gerrit merged patch set 1 01/19/17, 13:38

  8. Daniel Goerz commented on patch set 2 01/19/17, 15:04