Review TYPO3_7-6 Merged

51361[BUGFIX] Use reflection information in getGettablePropertyNames

Philipp Gampe CR +2 V +2 Normal +53 −15 updated 01/19/17, 13:58

Commit message

In \TYPO3\CMS\Extbase\Reflection\ObjectAccess there is a method to get
all available property names of an object. Currently all get/is/has
methods are joined as they can be fetch from Extbase as well. But for
those methods it is necessary to respect their arguments as Extbase
calls those functions without any argument.
This can trigger PHP warnings.

The patch uses a class reflection to get public properties and inspect
the method arguments. Only those functions without arguments or only
optional arguments are considered as valid property name.

Review

  • Code review CR +2
    • Philipp Gampe +2
  • Verified V +2
    • Philipp Gampe +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 68

  1. Philipp Gampe uploaded patch set 1 01/19/17, 13:29

  2. TYPO3com voted on patch set 1 V -1 01/19/17, 13:33 Completed build in 03m 53s on Thu, 19 Jan, 02:33 PM Test Summary: 1 of 38498 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-632

  3. Philipp Gampe voted on patch set 1 CR +2 V +2 01/19/17, 13:38

  4. Philipp Gampe voted on patch set 1 CR 0 V 0 01/19/17, 13:38

  5. Philipp Gampe updated the commit message in patch set 2 01/19/17, 13:51

  6. TYPO3com voted on patch set 2 V +1 01/19/17, 13:58 Completed build in 06m 47s on Thu, 19 Jan, 02:58 PM Test Summary: 38498 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-633

  7. Philipp Gampe voted on patch set 2 CR +2 V +2 01/19/17, 13:58

  8. Gerrit merged patch set 2 01/19/17, 13:58