Review main Merged

51365[BUGFIX] Fix invalid button group markup in scheduler

Andreas Kienast CR +2 V +2 Easy +3 −3 updated 01/23/17, 09:19

Commit message

An element with the class `btn-group` must not also have the class `btn`.
Such occurences are fixed in this patch.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Georg Ringer +1
  • Verified V +2
    • Wouter Wolters +2
    • Georg Ringer +1
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 56

  1. Andreas Kienast uploaded patch set 1 01/19/17, 20:56

  2. TYPO3com voted on patch set 1 V +1 01/19/17, 21:02 Completed build in 05m 31s on Thu, 19 Jan, 10:02 PM Test Summary: 54987 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6822

  3. Georg Ringer voted on patch set 1 CR +1 V +1 01/22/17, 20:24

  4. Riccardo De Contardi commented on patch set 1 V +1 01/22/17, 21:28

    after application of the patch, it seems that the string "btn btn-group" is no more present in the core.
  5. Wouter Wolters voted on patch set 1 CR +2 V +2 01/23/17, 09:19

  6. Gerrit merged patch set 1 01/23/17, 09:19