Review main Merged

51372[BUGFIX] FormEngine: Do not add <br> to readonly textarea content

Markus Klein CR +2 V +2 Easy +0 −3 updated 01/23/17, 06:58

Commit message

Multiline content is displayed in a textarea "as is" by the browser.
There is no need to add <br> tags.

Review

  • Code review CR +2
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Markus Klein uploaded patch set 1 01/20/17, 14:59

  2. TYPO3com voted on patch set 1 V +1 01/20/17, 15:05 Completed build in 05m 25s on Fri, 20 Jan, 04:04 PM Test Summary: 55161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6851

  3. Christian Kuhn commented on patch set 1 01/21/17, 09:28

    note: after patch "FormEngine element level refactoring" the type=text field will no longer call the none element.
  4. Georg Ringer commented on patch set 1 CR +1 V +1 01/22/17, 20:22

    still valid then for 7.6
  5. Benni Mack voted on patch set 1 CR +2 V +2 01/23/17, 06:57

  6. Gerrit merged patch set 1 01/23/17, 06:58

  7. Benni Mack commented on patch set 2 01/23/17, 06:58

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 83175379cb058f98f8939018b2292739611702b4