Review main Merged

51383[TASK] Render information msg in TS module with a callout

Georg Ringer CR +2 V +2 Easy +3 −2 updated 01/23/17, 09:39

Commit message

If a template record does not contain any constants, the information
should be rendered by a nice callout.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
  • Verified V +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Georg Ringer uploaded patch set 1 01/22/17, 19:21

  2. Andreas Kienast commented on patch set 1 CR -1 01/22/17, 19:23

    Why don't you use the <f:be.infobox> view helper?
  3. TYPO3com voted on patch set 1 V +1 01/22/17, 19:26 Completed build in 05m 09s on Sun, 22 Jan, 08:26 PM Test Summary: 55161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6886

  4. Georg Ringer uploaded patch set 2 01/22/17, 19:35

  5. TYPO3com voted on patch set 2 V +1 01/22/17, 19:40 Completed build in 04m 47s on Sun, 22 Jan, 08:40 PM Test Summary: 55161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6888

  6. Wouter Wolters voted on patch set 2 CR +1 V +1 01/23/17, 09:21

  7. Andreas Kienast voted on patch set 2 CR +2 V +2 01/23/17, 09:39

  8. Gerrit merged patch set 2 01/23/17, 09:39