Review main Merged

51388[BUGFIX] Remove empty option tag in fluid select viewhelper

Marcus Schwemer CR +2 V +2 Easy +1 −22 updated 02/01/17, 18:35

Commit message

Currently the select viewhelper produces an empty option tag, if no
argument "option" is provided. This is not needed.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Claus Due +1
  • Verified V +2
    • Jigal van Hemert +2
    • Claus Due +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1522

  1. Marcus Schwemer uploaded patch set 1 01/22/17, 21:29

  2. TYPO3com voted on patch set 1 V -1 01/22/17, 21:34 Completed build in 04m 44s on Sun, 22 Jan, 10:34 PM Test Summary: 6 of 55161 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6900

  3. Marcus Schwemer rebased onto patch set 2 01/22/17, 22:18

  4. Marcus Schwemer commented on patch set 2 01/22/17, 22:22

    The test can be removed as no option tag is needed within a select tag https://www.w3.org/TR/2016/WD-html51-20160310/sec-forms.html#the-select-element See "content-model": "Zero or more option, optgroup, and script-supporting elements."
  5. TYPO3com voted on patch set 2 V -1 01/22/17, 22:22 Completed build in 04m 21s on Sun, 22 Jan, 11:22 PM Test Summary: 6 of 55161 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6901

  6. Marcus Schwemer uploaded patch set 3 01/22/17, 22:26

  7. TYPO3com voted on patch set 3 V -1 01/22/17, 22:31 Completed build in 04m 20s on Sun, 22 Jan, 11:31 PM Test Summary: 55155 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6902

  8. Marcus Schwemer uploaded patch set 4 01/22/17, 22:38

  9. TYPO3com voted on patch set 4 V +1 01/22/17, 22:43 Completed build in 04m 33s on Sun, 22 Jan, 11:43 PM Test Summary: 55155 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6903

  10. Marcus Schwemer uploaded patch set 5 01/23/17, 07:55

  11. Marcus Schwemer commented on patch set 5 01/23/17, 08:00

    Added missing doc comment
  12. TYPO3com voted on patch set 5 V +1 01/23/17, 08:04 Completed build in 08m 18s on Mon, 23 Jan, 09:03 AM Test Summary: 55155 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6914

  13. Mona Muzaffar commented on patch set 5 V -1 01/27/17, 10:18

    I tested this with the fluid text & media element. i placed the select viewhelper above the div containing the bodytext. After installing your patch it doesn't contain an empty option tag anymore but also doesn't render any other HTML placed after the viewhelper. The select viewhelper just surrounds the content of the text & media element and the content of a header element, which was was placed after the text & media element in the backend.
  14. Marcus Schwemer uploaded patch set 6 01/31/17, 16:31

  15. Marcus Schwemer commented on patch set 6 01/31/17, 16:33

    Thanks for testing. According to the HTML spec an empty option tag is not needed for validity.
  16. TYPO3com voted on patch set 6 V +1 01/31/17, 16:36 Completed build in 04m 39s on Tue, 31 Jan, 05:36 PM Test Summary: 55649 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7286

  17. Claus Due commented on patch set 6 CR -1 01/31/17, 17:45

    Patch should be split in two - and the second refactoring patch could do a bit more than what is in this patch, e.g. regarding generating a hidden field. I believe this can be skipped if no options exist, manual or otherwise.

    SelectViewHelper.php:129

    This is, technically speaking, the only change in this patch set that is necessary. The rest is refactoring and I'd personally prefer if that was done in a second merge request.

    SelectViewHelper.php:149

    A <select> which has no options when posted doesn't cause a value in the Request arguments. So technically, if options are empty, we wouldn't need to register the field name for token generation?
  18. Marcus Schwemer uploaded patch set 7 02/01/17, 15:39

  19. TYPO3com voted on patch set 7 V +1 02/01/17, 15:44 Completed build in 05m 14s on Wed, 1 Feb, 04:44 PM Test Summary: 55727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7306

  20. Claus Due voted on patch set 7 CR +1 V +1 02/01/17, 15:53

  21. Jigal van Hemert voted on patch set 7 CR +2 V +2 02/01/17, 18:35

  22. Gerrit merged patch set 7 02/01/17, 18:35