Review main Merged

51397[BUGFIX] Fix SQL error in createEntryData

Thomas Hohn CR +2 V +2 Easy +2 −2 updated 01/26/17, 13:41

Commit message

The database field definition for ref_string is limited to varchar(200)
and can cause an SQL error when bigger strings are inserted.
In addition it makes sense to add a mb_substr() to avoid an error if
longer strings are inserted.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • TYPO3 GmbH TYPO3com +1 CI

Files 2

Review log 913

  1. Thomas Hohn uploaded patch set 1 01/23/17, 08:38

  2. TYPO3com voted on patch set 1 V +1 01/23/17, 08:44 Completed build in 05m 26s on Mon, 23 Jan, 09:44 AM Test Summary: 55161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6915

  3. Thomas Hohn updated the commit message in patch set 2 01/23/17, 12:13

  4. TYPO3com voted on patch set 2 V +1 01/23/17, 12:20 Completed build in 06m 03s on Mon, 23 Jan, 01:20 PM Test Summary: 55161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6930

  5. Tymoteusz Motylewski commented on patch set 2 01/23/17, 19:32

    typo: ^^being too Also please make commit header fit one line, and add description.
  6. Thomas Hohn updated the commit message in patch set 3 01/23/17, 20:18

  7. TYPO3com voted on patch set 3 V +1 01/23/17, 20:25 Completed build in 06m 47s on Mon, 23 Jan, 09:25 PM Test Summary: 55161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6946

  8. Thomas Hohn updated the commit message in patch set 4 01/26/17, 06:08

  9. TYPO3com voted on patch set 4 V +1 01/26/17, 06:13 Completed build in 05m 23s on Thu, 26 Jan, 07:13 AM Test Summary: 55149 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7047

  10. Georg Ringer voted on patch set 4 CR +1 V +1 01/26/17, 06:20

  11. Wouter Wolters voted on patch set 4 CR +1 01/26/17, 13:05

  12. Christian Kuhn voted on patch set 4 CR +2 V +2 01/26/17, 13:41

  13. Gerrit merged patch set 4 01/26/17, 13:41