Review main Merged

51398[FEATURE] Add new ViewHelper f:variable via Fluid 2.2.0

Claus Due CR +2 V +2 Easy +30 −0 updated 01/25/17, 20:28

Commit message

A new Fluid ViewHelper, `f:variable`, has become available
in TYPO3 after raising the minimum required version of the
Fluid engine to 2.2.0.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Thomas Hohn +1
  • Verified V +2
    • Georg Ringer +2
    • Thomas Hohn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1015

  1. Claus Due uploaded patch set 1 01/23/17, 11:36

  2. Claus Due updated the commit message in patch set 2 01/23/17, 11:37

  3. Mathias Brodala commented on patch set 3 01/23/17, 11:38

    Published edit on patch set 2.
  4. Claus Due uploaded patch set 4 01/23/17, 11:40

  5. Claus Due commented on patch set 1 01/23/17, 11:41

    Oops - sorry Mathias. If you edited the RST's topic I did the same :)
  6. TYPO3com voted on patch set 1 V +1 01/23/17, 11:43 Completed build in 06m 39s on Mon, 23 Jan, 12:43 PM Test Summary: 55161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6924

  7. TYPO3com voted on patch set 2 V +1 01/23/17, 11:45 Completed build in 07m 49s on Mon, 23 Jan, 12:45 PM Test Summary: 55161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6925

  8. TYPO3com voted on patch set 3 V +1 01/23/17, 11:47 Completed build in 08m 15s on Mon, 23 Jan, 12:47 PM Test Summary: 55161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6926

  9. Mathias Brodala commented on patch set 5 01/23/17, 11:48

    Published edit on patch set 4.
  10. TYPO3com voted on patch set 4 V +1 01/23/17, 11:48 Completed build in 07m 47s on Mon, 23 Jan, 12:48 PM Test Summary: 55161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6927

  11. Mathias Brodala commented on patch set 5 01/23/17, 11:48

    Once more with feeling. ;-)
  12. TYPO3com voted on patch set 5 V +1 01/23/17, 11:53 Completed build in 05m 25s on Mon, 23 Jan, 12:53 PM Test Summary: 55161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6928

  13. Thomas Hohn voted on patch set 5 CR +1 V +1 01/25/17, 20:22

  14. Georg Ringer voted on patch set 5 CR +2 V +2 01/25/17, 20:28

  15. Gerrit merged patch set 5 01/25/17, 20:28