51411[TASK] Deprecate visibility for internal variables in Datahandler class
Commit message
Review
-
Code review CR +2
- Morton Jonuschat +2
- Georg Ringer +1
-
Verified V +2
- Morton Jonuschat +2
- Georg Ringer +1
- TYPO3com +1 CI
Files 2
Review log 1015
-
Thomas Hohn uploaded patch set 1 01/24/17, 21:06
-
Thomas Hohn uploaded patch set 2 01/24/17, 21:08
-
TYPO3com voted on patch set 1 V +1 01/24/17, 21:12 Completed build in 05m 48s on Tue, 24 Jan, 10:12 PM Test Summary: 55161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6979
-
TYPO3com voted on patch set 2 V +1 01/24/17, 21:15 Completed build in 06m 45s on Tue, 24 Jan, 10:15 PM Test Summary: 55161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6980
-
Benni Mack commented on patch set 2 01/25/17, 05:47
Hey Thomas, thanks for your fix, however you can remove the !!! from the commit message as this patch is not breaking, but only adds deprecations. -
Morton Jonuschat commented on patch set 2 01/25/17, 06:02
Minor nits, not downvoting but would like to see it changed. 1) Scope in PHP lingo normally refers to self::, static:: or parent:: keywords. For public, protected or private the term is visibility. 2) As for the @todo comments I feel they are repeated too often. I would getting rid of them and instead use a slightly different @deprecated that states "visibility will be changed to protected in TYPO3 v9". -
Thomas Hohn uploaded patch set 3 01/25/17, 06:18
-
Thomas Hohn updated the commit message in patch set 4 01/25/17, 06:21
-
TYPO3com voted on patch set 3 V +1 01/25/17, 06:23 Completed build in 05m 13s on Wed, 25 Jan, 07:23 AM Test Summary: 55161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6992
-
TYPO3com voted on patch set 4 V +1 01/25/17, 06:26 Completed build in 04m 46s on Wed, 25 Jan, 07:25 AM Test Summary: 55161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6993
-
Mathias Schreiber commented on patch set 5 01/25/17, 07:38
Published edit on patch set 4. -
Georg Ringer voted on patch set 5 CR +1 V +1 01/25/17, 07:41
-
TYPO3com voted on patch set 5 V +1 01/25/17, 07:42 Completed build in 04m 12s on Wed, 25 Jan, 08:42 AM Test Summary: 55161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6995
-
Morton Jonuschat voted on patch set 5 CR +2 V +2 01/26/17, 02:06
-
Gerrit merged patch set 5 01/26/17, 02:06