Review main Merged

51423[TASK] Update php-cs-fixer to version 2.0

Anja Leichsenring CR +2 V +2 Normal +106 −48 updated 01/25/17, 17:17

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jan Helke +1
  • Verified V +2
    • Christian Kuhn +2
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1317

  1. Anja Leichsenring uploaded patch set 1 01/25/17, 12:38

  2. TYPO3com voted on patch set 1 V -1 01/25/17, 12:38 Completed build in 06s on Wed, 25 Jan, 01:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7012

  3. Anja Leichsenring uploaded patch set 2 01/25/17, 12:40

  4. TYPO3com voted on patch set 2 V +1 01/25/17, 12:47 Completed build in 07m 45s on Wed, 25 Jan, 01:47 PM Test Summary: 55149 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7013

  5. Jan Kiesewetter commented on patch set 2 CR -1 01/25/17, 12:48

    The ".php_cs" should be renamed to ".php_cs.dist". See https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/master/UPGRADE.md#config-file
  6. Anja Leichsenring commented on patch set 2 01/25/17, 12:50

    veto for the .dist. It is an option so a package provider can provide a default and users can override it with their own .php_cs. This is IMO not what we want for the TYPO3 core. Our CGLs are not subject to interpretation.
  7. Jan Kiesewetter commented on patch set 2 01/25/17, 13:00

    > veto for the .dist. It is an option so a package provider can > provide a default and users can override it with their own .php_cs. > This is IMO not what we want for the TYPO3 core. Our CGLs are not > subject to interpretation. Since the CI votes based on the .php_cs.dist file and no .php_cs file will be pushed i see no problem for the CGL.
  8. Anja Leichsenring commented on patch set 2 01/25/17, 13:08

    I don't want to provide that option in the first place. So .dist file is not necessary nor wanted.
  9. Anja Leichsenring uploaded patch set 3 01/25/17, 16:39

  10. TYPO3com voted on patch set 3 V +1 01/25/17, 16:46 Completed build in 06m 01s on Wed, 25 Jan, 05:46 PM Test Summary: 55149 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7029

  11. Anja Leichsenring uploaded patch set 4 01/25/17, 16:48

  12. Christian Kuhn commented on patch set 3 01/25/17, 16:49

    lets keep the .php_cs file for now, if we really need the .dist for whatever reason, we may adapt later.
  13. Christian Kuhn voted on patch set 4 CR +1 V +1 01/25/17, 16:50

  14. TYPO3com voted on patch set 4 V +1 01/25/17, 16:53 Completed build in 04m 47s on Wed, 25 Jan, 05:53 PM Test Summary: 55149 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7030

  15. Jan Helke voted on patch set 4 CR +1 V +1 01/25/17, 17:17

  16. Christian Kuhn voted on patch set 4 CR +2 V +2 01/25/17, 17:17

  17. Gerrit merged patch set 4 01/25/17, 17:17