Review main Merged Breaking

51437[!!!][TASK] Remove lockHashKeyWords functionality

Benni Mack CR +2 V +2 Normal +61 −46 updated 01/27/17, 11:01

Commit message

The TYPO3 Core used the "useragent" to create a hashbase
by default to harden the session hijacking functionality.

This very very old feature adds a tiny bit of security on top,
however it has the drawback that users get logged out (of BE or FE)
if their browser updates (due to evergreen browsers or security
updates as the user agent string changes). This is very inconvenient
for websites that use a very long session time for logged in users
in the frontend (or backend) when using TYPO3 as a platform or
application.

It was originally concepted so it could be extended but there is no
hook to do so, and extending all classes does not really make a lot
of sense in the hierarchical PHP class structure.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2
    • Georg Ringer +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 811

  1. Benni Mack uploaded patch set 1 01/26/17, 16:40

  2. Benni Mack commented on patch set 1 01/26/17, 16:41

    btw. I already talked to Helmut, Markus, Christian and Mattes about this change, and they are all fine with this change.
  3. TYPO3com voted on patch set 1 V +1 01/26/17, 16:45 Completed build in 04m 29s on Thu, 26 Jan, 05:45 PM Test Summary: 55205 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7072

  4. Benni Mack uploaded patch set 2 01/27/17, 09:00

  5. Benni Mack commented on patch set 3 01/27/17, 09:01

    Published edit on patch set 2.
  6. TYPO3com voted on patch set 2 V +1 01/27/17, 09:07 Completed build in 06m 15s on Fri, 27 Jan, 10:07 AM Test Summary: 55595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7093

  7. TYPO3com voted on patch set 3 V +1 01/27/17, 09:08 Completed build in 06m 25s on Fri, 27 Jan, 10:08 AM Test Summary: 55595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7094

  8. Christian Kuhn voted on patch set 3 CR +1 V +1 01/27/17, 09:41

  9. Georg Ringer voted on patch set 3 CR +1 V +1 01/27/17, 10:43

  10. Georg Ringer voted on patch set 3 CR +2 V +2 01/27/17, 11:01

  11. Gerrit merged patch set 3 01/27/17, 11:01