Review main Merged

51441[TASK] Add .php_cs.cache to .gitignore

Georg Ringer CR +2 V +2 Easy +1 −0 updated 01/27/17, 06:49

Commit message

The php-cs fixer creates a cache file which
should not be commited. Add it to the .gitgnore to avoid
any mistakes.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Thomas Hohn +1
    • Christian Kuhn +1
  • Verified V +2
    • Georg Ringer +2
    • Thomas Hohn +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1013

  1. Georg Ringer uploaded patch set 1 01/26/17, 20:26

  2. Wouter Wolters updated the commit message in patch set 2 01/26/17, 20:31

  3. Wouter Wolters voted on patch set 2 CR +1 01/26/17, 20:31

  4. TYPO3com voted on patch set 1 V +1 01/26/17, 20:32 Completed build in 06m 14s on Thu, 26 Jan, 09:32 PM Test Summary: 55595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7083

  5. TYPO3com voted on patch set 2 V +1 01/26/17, 20:36 Completed build in 04m 49s on Thu, 26 Jan, 09:36 PM Test Summary: 55595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7084

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 01/27/17, 06:00

  7. Christian Kuhn updated the commit message in patch set 3 01/27/17, 06:00

  8. Christian Kuhn commented on patch set 3 CR +1 V +1 01/27/17, 06:01

    added 7.6 since the fixer was upgraded in 7.6, too.
  9. TYPO3com voted on patch set 3 V +1 01/27/17, 06:06 Completed build in 05m 19s on Fri, 27 Jan, 07:06 AM Test Summary: 55595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7091

  10. Thomas Hohn voted on patch set 3 CR +1 V +1 01/27/17, 06:40

  11. Georg Ringer voted on patch set 3 CR +2 V +2 01/27/17, 06:48

  12. Gerrit merged patch set 3 01/27/17, 06:49

  13. Georg Ringer commented on patch set 4 01/27/17, 06:49

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 52fb853c3b15c822a4a5639e68872839f8bf2003