Review main Merged

51452[FEATURE] Show list of failed input fields in FormEngine

Andreas Kienast CR +2 V +2 Hard +344 −6 updated 02/06/17, 20:13

Commit message

When validating input fields of the FormEngine fails, a button is now
rendered into the least possible button bar in the module document header.
Clicking the button renders a list of all input elements whose validation
failed.

Clicking onto a field in that list automatically focuses the field in the
form.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Frank Nägler +2
  • Verified V +2
    • Georg Ringer +2
    • Frank Nägler +2

Issues 1

Files 11

Review log 2637

Show 712 earlier messages
  1. Andreas Kienast uploaded patch set 1 01/28/17, 21:08

  2. TYPO3com voted on patch set 1 V +1 01/28/17, 21:14 Completed build in 05m 14s on Sat, 28 Jan, 10:14 PM Test Summary: 55619 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7165

  3. Andreas Kienast uploaded patch set 2 01/28/17, 21:17

  4. TYPO3com voted on patch set 2 V +1 01/28/17, 21:23 Completed build in 05m 41s on Sat, 28 Jan, 10:23 PM Test Summary: 55619 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7166

  5. Andreas Kienast commented on patch set 2 CR -1 01/28/17, 21:27

    Fails for inline stuff
  6. Andreas Kienast uploaded patch set 3 01/28/17, 21:58

  7. Andreas Kienast uploaded patch set 4 01/28/17, 21:59

  8. TYPO3com voted on patch set 3 V +1 01/28/17, 22:05 Completed build in 06m 33s on Sat, 28 Jan, 11:05 PM Test Summary: 55619 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7167

  9. TYPO3com voted on patch set 4 V +1 01/28/17, 22:06 Completed build in 07m 08s on Sat, 28 Jan, 11:06 PM Test Summary: 55619 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7168

  10. Andreas Kienast uploaded patch set 5 01/28/17, 22:35

  11. TYPO3com voted on patch set 5 V +1 01/28/17, 22:40 Completed build in 04m 23s on Sat, 28 Jan, 11:40 PM Test Summary: 55619 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7169

  12. Andreas Kienast uploaded patch set 6 01/28/17, 22:47

  1. TYPO3com voted on patch set 6 V +1 01/28/17, 22:52 Completed build in 04m 31s on Sat, 28 Jan, 11:52 PM Test Summary: 55619 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7170

  2. Andreas Kienast uploaded patch set 7 01/29/17, 07:35

  3. TYPO3com voted on patch set 7 V +1 01/29/17, 07:39 Completed build in 04m 47s on Sun, 29 Jan, 08:39 AM Test Summary: 55619 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7176

  4. Andreas Kienast uploaded patch set 8 01/29/17, 10:47

  5. TYPO3com voted on patch set 8 V +1 01/29/17, 10:51 Completed build in 04m 36s on Sun, 29 Jan, 11:51 AM Test Summary: 55619 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7177

  6. Georg Ringer commented on patch set 8 CR +1 V +1 01/29/17, 19:58

    just some remarks: - the popover is too far right - shouldn't every new requireJS module be TypeScript first?
  7. Mona Muzaffar voted on patch set 8 V +1 01/30/17, 16:22

  8. Andreas Kienast commented on patch set 8 CR -1 02/02/17, 07:42

    Will rewrite the JS in TypeScript
  9. Andreas Kienast uploaded patch set 9 02/03/17, 21:25

  10. TYPO3com voted on patch set 9 V +1 02/03/17, 21:35 Completed build in 09m 40s on Fri, 3 Feb, 10:35 PM Test Summary: 55901 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7425

  11. Frans Saris commented on patch set 9 02/04/17, 09:02

    tsconfig.json:169

    isn't it more convenient to adjust this line? [ "../typo3/sysext/*/Resources/Private/TypeScript/*.ts", "../typo3/sysext/*/Resources/Private/TypeScript/**/*.ts" ]
  12. Andreas Kienast commented on patch set 9 02/04/17, 09:07

    tsconfig.json:169 Reply

    That change was automatically done by the build chain.
  13. Andreas Kienast commented on patch set 9 02/04/17, 09:12

    tsconfig.json:169 Reply

    But if you're talking about that special line and not about the change of this file in general: I'm not that deep in TS yet and if a change is necessary, I'd do that in a separate patch :)
  14. Frank Nägler commented on patch set 9 02/04/17, 09:24

    tsconfig.json:169 Reply

    The filesGlob pattern match the files we will monitor, if a new file is found and compiled the ts file is added to the files array. I have not found a setting to prevent it, the compiler do it.

    FormEngineReview.ts:16

    The declare statements could be removed after the modules are TypeScript files. I would suggest to add a comment / todo marker

    ColorPicker.js:34

    an added comma for the last element? The compiler should prevent this. I can't test the patch now on my machine but it looks wired.
  15. Andreas Kienast uploaded patch set 10 02/04/17, 09:39

  16. TYPO3com voted on patch set 10 V +1 02/04/17, 09:44 Completed build in 05m 05s on Sat, 4 Feb, 10:44 AM Test Summary: 55901 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7450

  17. Andreas Kienast uploaded patch set 11 02/06/17, 18:55

  18. Markus Klein commented on patch set 11 02/06/17, 19:27

    FormEngineReview.js:112

    according to jquery docs this is deprecated. use $(function() {}) directly.
  19. Georg Ringer voted on patch set 11 CR +1 V +1 02/06/17, 19:52

  20. Frank Nägler commented on patch set 11 CR -1 02/06/17, 20:02

    nice patch, thx.

    FormEngineReview.ts:94

    agree with Markus, $(function() ... should be used here

    FormEngineReview.ts:97

    we should use a variable for $(document) like: let $document = $(document)
  21. Andreas Kienast uploaded patch set 12 02/06/17, 20:06

  22. Frank Nägler voted on patch set 12 CR +2 V +2 02/06/17, 20:11

  23. Georg Ringer voted on patch set 12 CR +2 V +2 02/06/17, 20:12

  24. Gerrit merged patch set 12 02/06/17, 20:12

  25. TYPO3com commented on patch set 12 02/06/17, 20:13 Completed build in 06m 33s on Mon, 6 Feb, 09:13 PM Test Summary: 1 of 56139 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7625