51452[FEATURE] Show list of failed input fields in FormEngine
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Frank Nägler +2
-
Verified V +2
- Georg Ringer +2
- Frank Nägler +2
Issues 1
Files 11
- Build/Resources/Public/Less/TYPO3/_element_popover.less+18 −2
- Build/Resources/Public/Less/TYPO3/_main_form.less+1 −1
- Build/tsconfig.json4+3 −2
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php+1 −0
- typo3/sysext/backend/Resources/Private/TypeScript/FormEngineReview.ts3new+166 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+11 −0
- typo3/sysext/backend/Resources/Public/JavaScript/ColorPicker.js1+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngineReview.js1new+122 −0
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngineValidation.js+1 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-79521-ShowListOfFailedInputElementsInFormEngine.rstnew+17 −0
- typo3/sysext/lang/Resources/Private/Language/locallang_alt_doc.xlf+3 −0
Review log 2637
Show 712 earlier messages
-
Andreas Kienast uploaded patch set 1 01/28/17, 21:08
-
TYPO3com voted on patch set 1 V +1 01/28/17, 21:14 Completed build in 05m 14s on Sat, 28 Jan, 10:14 PM Test Summary: 55619 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7165
-
Andreas Kienast uploaded patch set 2 01/28/17, 21:17
-
TYPO3com voted on patch set 2 V +1 01/28/17, 21:23 Completed build in 05m 41s on Sat, 28 Jan, 10:23 PM Test Summary: 55619 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7166
-
Andreas Kienast commented on patch set 2 CR -1 01/28/17, 21:27
Fails for inline stuff -
Andreas Kienast uploaded patch set 3 01/28/17, 21:58
-
Andreas Kienast uploaded patch set 4 01/28/17, 21:59
-
TYPO3com voted on patch set 3 V +1 01/28/17, 22:05 Completed build in 06m 33s on Sat, 28 Jan, 11:05 PM Test Summary: 55619 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7167
-
TYPO3com voted on patch set 4 V +1 01/28/17, 22:06 Completed build in 07m 08s on Sat, 28 Jan, 11:06 PM Test Summary: 55619 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7168
-
Andreas Kienast uploaded patch set 5 01/28/17, 22:35
-
TYPO3com voted on patch set 5 V +1 01/28/17, 22:40 Completed build in 04m 23s on Sat, 28 Jan, 11:40 PM Test Summary: 55619 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7169
-
Andreas Kienast uploaded patch set 6 01/28/17, 22:47
-
TYPO3com voted on patch set 6 V +1 01/28/17, 22:52 Completed build in 04m 31s on Sat, 28 Jan, 11:52 PM Test Summary: 55619 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7170
-
Andreas Kienast uploaded patch set 7 01/29/17, 07:35
-
TYPO3com voted on patch set 7 V +1 01/29/17, 07:39 Completed build in 04m 47s on Sun, 29 Jan, 08:39 AM Test Summary: 55619 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7176
-
Andreas Kienast uploaded patch set 8 01/29/17, 10:47
-
TYPO3com voted on patch set 8 V +1 01/29/17, 10:51 Completed build in 04m 36s on Sun, 29 Jan, 11:51 AM Test Summary: 55619 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7177
-
Georg Ringer commented on patch set 8 CR +1 V +1 01/29/17, 19:58
just some remarks: - the popover is too far right - shouldn't every new requireJS module be TypeScript first? -
Mona Muzaffar voted on patch set 8 V +1 01/30/17, 16:22
-
Andreas Kienast commented on patch set 8 CR -1 02/02/17, 07:42
Will rewrite the JS in TypeScript -
Andreas Kienast uploaded patch set 9 02/03/17, 21:25
-
TYPO3com voted on patch set 9 V +1 02/03/17, 21:35 Completed build in 09m 40s on Fri, 3 Feb, 10:35 PM Test Summary: 55901 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7425
-
Frans Saris commented on patch set 9 02/04/17, 09:02
tsconfig.json:169isn't it more convenient to adjust this line? [ "../typo3/sysext/*/Resources/Private/TypeScript/*.ts", "../typo3/sysext/*/Resources/Private/TypeScript/**/*.ts" ] -
Andreas Kienast commented on patch set 9 02/04/17, 09:07
tsconfig.json:169ReplyThat change was automatically done by the build chain. -
Andreas Kienast commented on patch set 9 02/04/17, 09:12
tsconfig.json:169ReplyBut if you're talking about that special line and not about the change of this file in general: I'm not that deep in TS yet and if a change is necessary, I'd do that in a separate patch :) -
Frank Nägler commented on patch set 9 02/04/17, 09:24
tsconfig.json:169ReplyThe filesGlob pattern match the files we will monitor, if a new file is found and compiled the ts file is added to the files array. I have not found a setting to prevent it, the compiler do it.FormEngineReview.ts:16The declare statements could be removed after the modules are TypeScript files. I would suggest to add a comment / todo markerColorPicker.js:34an added comma for the last element? The compiler should prevent this. I can't test the patch now on my machine but it looks wired. -
Andreas Kienast uploaded patch set 10 02/04/17, 09:39
-
TYPO3com voted on patch set 10 V +1 02/04/17, 09:44 Completed build in 05m 05s on Sat, 4 Feb, 10:44 AM Test Summary: 55901 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7450
-
Andreas Kienast uploaded patch set 11 02/06/17, 18:55
-
Markus Klein commented on patch set 11 02/06/17, 19:27
FormEngineReview.js:112according to jquery docs this is deprecated. use $(function() {}) directly. -
Georg Ringer voted on patch set 11 CR +1 V +1 02/06/17, 19:52
-
Frank Nägler commented on patch set 11 CR -1 02/06/17, 20:02
nice patch, thx.FormEngineReview.ts:94agree with Markus, $(function() ... should be used hereFormEngineReview.ts:97we should use a variable for $(document) like: let $document = $(document) -
Andreas Kienast uploaded patch set 12 02/06/17, 20:06
-
Frank Nägler voted on patch set 12 CR +2 V +2 02/06/17, 20:11
-
Georg Ringer voted on patch set 12 CR +2 V +2 02/06/17, 20:12
-
Gerrit merged patch set 12 02/06/17, 20:12
-
TYPO3com commented on patch set 12 02/06/17, 20:13 Completed build in 06m 33s on Mon, 6 Feb, 09:13 PM Test Summary: 1 of 56139 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7625