Review TYPO3_7-6 Merged

51454[CLEANUP] Simplify updating of timestamp in writeForeignField

Andreas Kienast CR +2 V +2 Easy +1 −15 updated 01/29/17, 11:23

Commit message

There is no need to check the record we are updating -
since we update it anyway, update timestamp too and
save both a call to getRecord and a loop through fields,
casting and checking each field value comparing to DB.

Review

  • Code review CR +2
    • Andreas Kienast +2
  • Verified V +2
    • Andreas Kienast +2

Issues 1

Files 1

Review log 34

  1. Andreas Kienast commented on patch set 1 01/29/17, 11:16

    Cherry Picked from branch master.
  2. Andreas Kienast voted on patch set 1 CR +2 V +2 01/29/17, 11:16

  3. Gerrit merged patch set 1 01/29/17, 11:16

  4. TYPO3com commented on patch set 1 01/29/17, 11:23 Completed build in 07m 25s on Sun, 29 Jan, 12:23 PM Test Summary: 38571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-675