Review main Merged

51460[TASK] Use “error” icon for validation failures in FormEngine

Andreas Kienast CR +2 V +2 Easy +2 −4 updated 01/30/17, 12:36

Commit message

Currently, a warning sign is rendered next to field labels whose
validation failed. Failed validations are errors and thus another icon
should be rendered. With this patch, a red circle containing an
exclamation mark is rendered. It’s the same icon as in the tabs holding
affected fields.

Review

  • Code review CR +2
    • Benni Mack +2
    • Thomas Hohn +1
    • Georg Ringer +1
  • Verified V +2
    • Benni Mack +2
    • Thomas Hohn +1
    • Georg Ringer +1
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Andreas Kienast uploaded patch set 1 01/29/17, 20:38

  2. Andreas Kienast uploaded patch set 2 01/29/17, 20:38

  3. TYPO3com voted on patch set 1 V +1 01/29/17, 20:44 Completed build in 06m 17s on Sun, 29 Jan, 09:44 PM Test Summary: 55655 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7197

  4. TYPO3com voted on patch set 2 V +1 01/29/17, 20:44 Completed build in 05m 56s on Sun, 29 Jan, 09:44 PM Test Summary: 55655 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7198

  5. Riccardo De Contardi commented on patch set 2 V +1 01/29/17, 20:45

    Verified using EXT:styleguide
  6. Georg Ringer voted on patch set 2 CR +1 V +1 01/30/17, 06:32

  7. Thomas Hohn voted on patch set 2 CR +1 V +1 01/30/17, 12:25

  8. Benni Mack voted on patch set 2 CR +2 V +2 01/30/17, 12:36

  9. Gerrit merged patch set 2 01/30/17, 12:36