Review main Merged

51469[BUGFIX] Localize tt_content_defValues in new content element wizard

Eric Chavaillaz CR +2 V +2 Easy +1 −1 updated 03/15/17, 10:37

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Jörg Bösche +1
  • Verified V +2
    • Christian Kuhn +2
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1115

  1. Eric Chavaillaz uploaded patch set 1 01/30/17, 13:12

  2. Tymoteusz Motylewski commented on patch set 1 01/30/17, 13:17

    Hi Thanks for your contribution. Can you give more context/description about the issue and the solution? Is this feature documented somewhere already? Then it would be a bugfix, if it's a new feature, than it needs a [FEATURE] tag instead of [TASK] and can not be targeted to v7
  3. TYPO3com voted on patch set 1 V +1 01/30/17, 13:19 Completed build in 06m 54s on Mon, 30 Jan, 02:19 PM Test Summary: 55655 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7226

  4. Daniel Goerz commented on patch set 1 01/30/17, 15:04

    Would rephrase this to "Localize tt_content_defValues in new content element wizard" And maybe change to BUGFIX?
  5. Eric Chavaillaz updated the commit message in patch set 2 01/30/17, 15:12

  6. Eric Chavaillaz commented on patch set 2 01/30/17, 15:13

    Done Daniel, thanks for the feedback.
  7. TYPO3com voted on patch set 2 V -1 01/30/17, 15:18 Completed build in 06m 06s on Mon, 30 Jan, 04:18 PM Test Summary: 55552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7238

  8. Daniel Goerz commented on patch set 2 CR +1 01/30/17, 15:23

    I don't think the -1 has anything to do with this patch
  9. Riccardo De Contardi voted on patch set 2 V +1 03/11/17, 21:25

  10. TYPO3com commented on patch set 2 03/12/17, 10:43 Completed build in 19h 37m 52s on Sun, 12 Mar, 11:43 AM Test Summary: 55552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7238

  11. TYPO3com voted on patch set 2 V +1 03/12/17, 10:53 Completed build in 08m 24s on Sun, 12 Mar, 11:53 AM Test Summary: 56458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9074

  12. Jörg Bösche voted on patch set 2 CR +1 03/13/17, 21:38

  13. Christian Kuhn voted on patch set 2 CR +2 V +2 03/15/17, 10:36

  14. Gerrit merged patch set 2 03/15/17, 10:36

  15. Christian Kuhn commented on patch set 3 03/15/17, 10:37

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 4c0e1d9110280b0fe6258c2e6f8cdfdcfc6c42f9