Review main Merged

51475[BUGFIX] Correct handling of ObjectStorage objects in PaginateController

Nicole Hummel CR +2 V +2 Easy +22 −2 updated 02/25/17, 10:53

Commit message

The current implementation for getting paginated items from ObjectStorage
objects in TYPO3\CMS\Fluid\ViewHelpers\Widget\Controller\PaginateController
enforces null items if the count of objects is lower than the
itemsPerPage count. This patch calculates the correct count and returns
valid items only.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Jasmina Ließmann +1
    • Christian Matthes +1
    • Jörg Bösche +1
  • Verified V +2
    • Helmut Hummel +2
    • Jasmina Ließmann +1
    • Christian Matthes +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 911

  1. Nicole Hummel uploaded patch set 1 01/30/17, 18:04

  2. TYPO3com voted on patch set 1 V +1 01/30/17, 18:09 Completed build in 05m 36s on Mon, 30 Jan, 07:09 PM Test Summary: 55655 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7241

  3. Nicole Hummel uploaded patch set 2 01/30/17, 18:16

  4. TYPO3com voted on patch set 2 V +1 01/30/17, 18:20 Completed build in 04m 50s on Mon, 30 Jan, 07:20 PM Test Summary: 55661 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7243

  5. Jasmina Ließmann voted on patch set 2 CR +1 01/30/17, 22:16

  6. Jasmina Ließmann voted on patch set 2 V +1 02/13/17, 13:13

  7. Christian Matthes voted on patch set 2 CR +1 V +1 02/13/17, 16:08

  8. Jörg Bösche voted on patch set 2 CR +1 02/23/17, 18:41

  9. Helmut Hummel voted on patch set 2 CR +2 V +2 02/25/17, 10:24

  10. Gerrit merged patch set 2 02/25/17, 10:24

  11. Nicole Hummel commented on patch set 3 02/25/17, 10:53

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 57d39c8663080fc04ab3346d1d8c619214c959b6