Review main Merged

51479[FEATURE] Show link information below input field

Georg Ringer CR +2 V +2 Normal +160 −3 updated 02/06/17, 19:47

Commit message

Render link information below a link field to help editors.
Instead of 't3://page?uid=92 _top "a class" "a title"' the user
will get relevant information.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Markus Klein +1
    • Christian Kuhn +1
  • Verified V +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 2634

Show 69 earlier messages
  1. Georg Ringer uploaded patch set 1 01/30/17, 22:28

  2. TYPO3com voted on patch set 1 V +1 01/30/17, 22:35 Completed build in 06m 36s on Mon, 30 Jan, 11:35 PM Test Summary: 55655 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7260

  3. Riccardo De Contardi commented on patch set 1 V +1 01/30/17, 22:41

    seems to work; the only missing thing I noticed so far is a link to a page and an internal anchor to a content element like: t3://page?uid=124#304
  4. Georg Ringer rebased onto patch set 2 02/01/17, 11:13

  5. TYPO3com voted on patch set 2 V +1 02/01/17, 11:19 Completed build in 06m 36s on Wed, 1 Feb, 12:19 PM Test Summary: 55733 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7299

  6. Georg Ringer uploaded patch set 3 02/02/17, 07:23

  7. TYPO3com voted on patch set 3 V +1 02/02/17, 07:30 Completed build in 06m 35s on Thu, 2 Feb, 08:30 AM Test Summary: 55727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7324

  8. Riccardo De Contardi commented on patch set 3 V +1 02/03/17, 20:33

    Verified with the header field. As I wrote on my previous comment, that would be great if the link t3://page?uid=122#123 would be translated to: /Home/Page/[122#123] if the content object has no title /Home/Page/[122#title] if the content object has a title
  9. Georg Ringer updated the commit message in patch set 4 02/06/17, 07:36

  1. TYPO3com voted on patch set 4 V +1 02/06/17, 07:42 Completed build in 06m 02s on Mon, 6 Feb, 08:42 AM Test Summary: 55955 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7544

  2. Andreas Kienast commented on patch set 4 CR -1 02/06/17, 16:45

    jquery.clearable.js:53

    I dislike we need to patch a 3rd party library
  3. Andreas Kienast commented on patch set 4 02/06/17, 16:55

    on it
  4. Andreas Kienast commented on patch set 4 02/06/17, 17:21

    Never mind, I thought the clearable thing is a 3rd party lib
  5. Andreas Kienast uploaded patch set 5 02/06/17, 18:02

  6. TYPO3com voted on patch set 5 V +1 02/06/17, 18:08 Completed build in 05m 26s on Mon, 6 Feb, 07:08 PM Test Summary: 55967 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7609

  7. Christian Kuhn commented on patch set 5 02/06/17, 18:41

    InputLinkElement.php:199

    if that explanation is added below other wizards, then please implement it as FieldWizard renderType
  8. Christian Kuhn commented on patch set 5 02/06/17, 18:46

    InputLinkElement.php:199 Reply

    and, i'd probably show the linkexplanation between main field and other wizards (like the localization diff field wizards)
  9. Christian Kuhn commented on patch set 5 02/06/17, 19:08

    InputLinkElement.php:199 Reply

    uhm, ok, that's jsut for the "additionalAttributes" ... looks fishy, somehow.
  10. Christian Kuhn voted on patch set 5 CR -1 02/06/17, 19:17

  11. Benjamin Kott commented on patch set 5 02/06/17, 19:28

    Looks fine - we can finetune that until LTS
  12. Christian Kuhn uploaded patch set 6 02/06/17, 19:31

  13. Christian Kuhn commented on patch set 6 CR +1 V +1 02/06/17, 19:36

    really like this patch, very nice ux improvement for editors. we should have a small ajax handler to better cope with changed values, but this could be a second patch.
  14. TYPO3com voted on patch set 6 V -1 02/06/17, 19:37 Completed build in 06m 06s on Mon, 6 Feb, 08:37 PM Test Summary: 56115 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7615

  15. Christian Kuhn uploaded patch set 7 02/06/17, 19:38

  16. Christian Kuhn uploaded patch set 8 02/06/17, 19:39

  17. Christian Kuhn voted on patch set 8 CR +1 V +1 02/06/17, 19:39

  18. Andreas Kienast commented on patch set 8 CR +2 V +1 02/06/17, 19:40

    waiting for Bamboo
  19. Markus Klein voted on patch set 8 CR +1 02/06/17, 19:41

  20. Markus Klein commented on patch set 8 CR -2 02/06/17, 19:44

    one sec pls
  21. TYPO3com voted on patch set 7 V +1 02/06/17, 19:45 Completed build in 06m 33s on Mon, 6 Feb, 08:45 PM Test Summary: 56115 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7616

  22. TYPO3com voted on patch set 8 V +1 02/06/17, 19:46 Completed build in 07m 05s on Mon, 6 Feb, 08:46 PM Test Summary: 56115 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7617

  23. Markus Klein commented on patch set 8 CR +1 02/06/17, 19:46

    clear
  24. Andreas Kienast voted on patch set 8 V +2 02/06/17, 19:47

  25. Gerrit merged patch set 8 02/06/17, 19:47