51479[FEATURE] Show link information below input field
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Markus Klein +1
- Christian Kuhn +1
-
Verified V +2
- Andreas Kienast +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/backend/Classes/Form/Element/InputLinkElement.php3+113 −2
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine.js+23 −0
- typo3/sysext/backend/Resources/Public/JavaScript/jquery.clearable.js1+2 −1
- typo3/sysext/core/Documentation/Changelog/master/Feature-28171-ImprovedLinkFieldInFormEngine.rstnew+22 −0
Review log 2634
Show 69 earlier messages
-
Georg Ringer uploaded patch set 1 01/30/17, 22:28
-
TYPO3com voted on patch set 1 V +1 01/30/17, 22:35 Completed build in 06m 36s on Mon, 30 Jan, 11:35 PM Test Summary: 55655 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7260
-
Riccardo De Contardi commented on patch set 1 V +1 01/30/17, 22:41
seems to work; the only missing thing I noticed so far is a link to a page and an internal anchor to a content element like: t3://page?uid=124#304 -
Georg Ringer rebased onto patch set 2 02/01/17, 11:13
-
TYPO3com voted on patch set 2 V +1 02/01/17, 11:19 Completed build in 06m 36s on Wed, 1 Feb, 12:19 PM Test Summary: 55733 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7299
-
Georg Ringer uploaded patch set 3 02/02/17, 07:23
-
TYPO3com voted on patch set 3 V +1 02/02/17, 07:30 Completed build in 06m 35s on Thu, 2 Feb, 08:30 AM Test Summary: 55727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7324
-
Riccardo De Contardi commented on patch set 3 V +1 02/03/17, 20:33
Verified with the header field. As I wrote on my previous comment, that would be great if the link t3://page?uid=122#123 would be translated to: /Home/Page/[122#123] if the content object has no title /Home/Page/[122#title] if the content object has a title -
Georg Ringer updated the commit message in patch set 4 02/06/17, 07:36
-
TYPO3com voted on patch set 4 V +1 02/06/17, 07:42 Completed build in 06m 02s on Mon, 6 Feb, 08:42 AM Test Summary: 55955 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7544
-
Andreas Kienast commented on patch set 4 CR -1 02/06/17, 16:45
jquery.clearable.js:53I dislike we need to patch a 3rd party library -
Andreas Kienast commented on patch set 4 02/06/17, 16:55
on it -
Andreas Kienast commented on patch set 4 02/06/17, 17:21
Never mind, I thought the clearable thing is a 3rd party lib -
Andreas Kienast uploaded patch set 5 02/06/17, 18:02
-
TYPO3com voted on patch set 5 V +1 02/06/17, 18:08 Completed build in 05m 26s on Mon, 6 Feb, 07:08 PM Test Summary: 55967 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7609
-
Christian Kuhn commented on patch set 5 02/06/17, 18:41
InputLinkElement.php:199if that explanation is added below other wizards, then please implement it as FieldWizard renderType -
Christian Kuhn commented on patch set 5 02/06/17, 18:46
InputLinkElement.php:199Replyand, i'd probably show the linkexplanation between main field and other wizards (like the localization diff field wizards) -
Christian Kuhn commented on patch set 5 02/06/17, 19:08
InputLinkElement.php:199Replyuhm, ok, that's jsut for the "additionalAttributes" ... looks fishy, somehow. -
Christian Kuhn voted on patch set 5 CR -1 02/06/17, 19:17
-
Benjamin Kott commented on patch set 5 02/06/17, 19:28
Looks fine - we can finetune that until LTS -
Christian Kuhn uploaded patch set 6 02/06/17, 19:31
-
Christian Kuhn commented on patch set 6 CR +1 V +1 02/06/17, 19:36
really like this patch, very nice ux improvement for editors. we should have a small ajax handler to better cope with changed values, but this could be a second patch. -
TYPO3com voted on patch set 6 V -1 02/06/17, 19:37 Completed build in 06m 06s on Mon, 6 Feb, 08:37 PM Test Summary: 56115 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7615
-
Christian Kuhn uploaded patch set 7 02/06/17, 19:38
-
Christian Kuhn uploaded patch set 8 02/06/17, 19:39
-
Christian Kuhn voted on patch set 8 CR +1 V +1 02/06/17, 19:39
-
Andreas Kienast commented on patch set 8 CR +2 V +1 02/06/17, 19:40
waiting for Bamboo -
Markus Klein voted on patch set 8 CR +1 02/06/17, 19:41
-
Markus Klein commented on patch set 8 CR -2 02/06/17, 19:44
one sec pls -
TYPO3com voted on patch set 7 V +1 02/06/17, 19:45 Completed build in 06m 33s on Mon, 6 Feb, 08:45 PM Test Summary: 56115 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7616
-
TYPO3com voted on patch set 8 V +1 02/06/17, 19:46 Completed build in 07m 05s on Mon, 6 Feb, 08:46 PM Test Summary: 56115 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7617
-
Markus Klein commented on patch set 8 CR +1 02/06/17, 19:46
clear -
Andreas Kienast voted on patch set 8 V +2 02/06/17, 19:47
-
Gerrit merged patch set 8 02/06/17, 19:47