Review main Merged

51484[TASK] Clear search field in Install Tool with ESC

Georg Ringer CR +2 V +2 Easy +3 −0 updated 01/31/17, 11:19

Commit message

As the search in the Install Tool > All configuration can be
triggered by using CTRL + f, it should also listen on the
ESC key to clear the search again.

Review

  • Code review CR +2
    • Philipp Gampe +2
    • Markus Klein +1
    • Marco Huber +1
    • Andreas Kienast +1
  • Verified V +2
    • Philipp Gampe +2
    • Marco Huber +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1721

  1. Georg Ringer uploaded patch set 1 01/31/17, 10:35

  2. Georg Ringer updated the commit message in patch set 2 01/31/17, 10:36

  3. Andreas Kienast commented on patch set 2 01/31/17, 10:37

    Please add a comment that everyone known that keyCode 27 = Esc :)
  4. TYPO3com voted on patch set 1 V +1 01/31/17, 10:40 Completed build in 05m 35s on Tue, 31 Jan, 11:40 AM Test Summary: 55655 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7273

  5. TYPO3com voted on patch set 2 V +1 01/31/17, 10:42 Completed build in 05m 18s on Tue, 31 Jan, 11:42 AM Test Summary: 55655 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7274

  6. Philipp Gampe voted on patch set 2 CR +1 V +1 01/31/17, 10:46

  7. Thomas Hohn voted on patch set 2 CR +1 V +1 01/31/17, 10:46

  8. Andreas Kienast commented on patch set 2 CR -1 01/31/17, 10:46

    on it
  9. Andreas Kienast uploaded patch set 4 01/31/17, 10:47

  10. Wouter Wolters commented on patch set 2 CR -1 01/31/17, 10:47

    Install.js:738

    wrong indentation.
  11. Andreas Kienast voted on patch set 4 CR +1 V +1 01/31/17, 10:47

  12. Wouter Wolters voted on patch set 4 CR +1 01/31/17, 10:47

  13. Markus Klein commented on patch set 5 01/31/17, 10:48

    Published edit on patch set 4.
  14. Markus Klein voted on patch set 5 CR +1 01/31/17, 10:48

  15. Andreas Kienast voted on patch set 5 CR +1 V +1 01/31/17, 10:49

  16. TYPO3com voted on patch set 4 V +1 01/31/17, 10:53 Completed build in 05m 55s on Tue, 31 Jan, 11:53 AM Test Summary: 55655 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7275

  17. TYPO3com voted on patch set 5 V +1 01/31/17, 10:54 Completed build in 06m 24s on Tue, 31 Jan, 11:54 AM Test Summary: 55655 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7276

  18. Marco Huber voted on patch set 5 CR +1 V +1 01/31/17, 11:13

  19. Philipp Gampe voted on patch set 5 CR +2 V +2 01/31/17, 11:18

  20. Gerrit merged patch set 5 01/31/17, 11:19

  21. Philipp Gampe commented on patch set 6 01/31/17, 11:19

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 32805dc6e1841505f6533afe93091027fc237a40