51489[BUGFIX] Wrong computed baseURL with FE editing RTE
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Mona Muzaffar +1
-
Verified V +2
- Benni Mack +2
- Mona Muzaffar +1
- TYPO3com +1 CI
Issues 3
Files 2
Review log 910
-
Pierrick Caillon uploaded patch set 1 01/31/17, 13:19
-
TYPO3com voted on patch set 1 V +1 01/31/17, 13:26 Completed build in 06m 13s on Tue, 31 Jan, 02:26 PM Test Summary: 55655 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7282
-
Benni Mack voted on patch set 1 CR +1 V +1 02/01/17, 05:40
-
Jigal van Hemert commented on patch set 1 02/01/17, 07:59
What about not using a regexp at all (see comment)?Config.js:60Why don't we let the browser do the hard work: var link = document.createElement('a'); link.setAttribute('href', this.baseURL); this.baseURL = link.protocol+'//'+link.hostname+(link.port ? ':'+link.port: ''); -
Mona Muzaffar voted on patch set 1 CR +1 V +1 02/07/17, 10:32
-
Pierrick Caillon commented on patch set 1 02/07/17, 10:42
Config.js:60ReplyThis solution does not work when TYPO3 is not installed on website root. i.e. installed in a subfolder. -
Benni Mack voted on patch set 1 CR +2 V +2 03/23/17, 08:24
-
Gerrit merged patch set 1 03/23/17, 08:24
-
Pierrick Caillon commented on patch set 2 03/23/17, 09:18
How should the patch for branches 7.6 and 6.2 be provided? (already attached on the issue) -
Jigal van Hemert commented on patch set 2 03/24/17, 14:11
> How should the patch for branches 7.6 and 6.2 be provided? (already > attached on the issue) Just pushed a patch for 7.6 (see link in the "cherry picks" area. The idea is to keep the same Change-Id in the commit message and push it to the 7.6 branch. It's not a completely straight backport so it should be tested before merging in 7.6. I'm not sure if it should go to 6.2 because that version is almost EOL.