Review main Merged

51497[TASK] Refactor methods in DataHandler related to page delete access

Stephan Großberndt CR +2 V +2 Normal +85 −45 updated 03/22/17, 21:30

Commit message

* Removes usage of `rmComma()` and deprecates it
* Replaces usage of `noRecordsFromUnallowedTables()` with protected
method and deprecates it
* Removes duplicated code
* Improves variable names and type safety

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Thomas Hohn +1
  • Verified V +2
    • Jigal van Hemert +2
    • Thomas Hohn +1
    • TYPO3com +1 CI

Files 3

Review log 910

  1. Stephan Großberndt uploaded patch set 1 02/01/17, 13:07

  2. TYPO3com voted on patch set 1 V +1 02/01/17, 13:12 Completed build in 05m 13s on Wed, 1 Feb, 02:12 PM Test Summary: 55733 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7302

  3. Thomas Hohn commented on patch set 1 CR +1 02/01/17, 13:36

    Seems more like a CLEANUP task though

    DataHandler.php:8098

    If the $pageIds gets very large the in clause could crash with an SQL error
  4. Jigal van Hemert commented on patch set 1 CR +1 V +1 02/01/17, 19:21

    DataHandler.php:8098 Reply

    Sure, but that was also the case before this patch.
  5. Georg Ringer commented on patch set 1 02/01/17, 19:43

    GeneralUtility.php:1212

    please don't mix changes. this change has nothing to do with the initial cleanup. this makes it just harder to review.
  6. Stephan Großberndt commented on patch set 1 02/01/17, 22:46

    In general I'm with you Georg, but I spotted that during research for that patch and it's really not worth a single patch itself. If you insist, I'll upload a new PS without that. Since it's only a comment typo I hope you are ok with it as it is.

    DataHandler.php:8098 Reply

    There are lots of places in the core where that applies. that should be solved on a general basis and in a different patch.
  7. Thomas Hohn commented on patch set 1 02/02/17, 06:27

    DataHandler.php:8098 Reply

    I agree - I would also rather get of the NOT in since they are more expensive - and turning an IN () into something else is not always a no brainer ;-)
  8. Thomas Hohn commented on patch set 1 V +1 02/07/17, 14:18

    Testet
  9. Jigal van Hemert voted on patch set 1 CR +2 V +2 03/22/17, 21:30

  10. Gerrit merged patch set 1 03/22/17, 21:30