51497[TASK] Refactor methods in DataHandler related to page delete access
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Thomas Hohn +1
-
Verified V +2
- Jigal van Hemert +2
- Thomas Hohn +1
- TYPO3com +1 CI
Files 3
Review log 910
-
Stephan Großberndt uploaded patch set 1 02/01/17, 13:07
-
TYPO3com voted on patch set 1 V +1 02/01/17, 13:12 Completed build in 05m 13s on Wed, 1 Feb, 02:12 PM Test Summary: 55733 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7302
-
Thomas Hohn commented on patch set 1 CR +1 02/01/17, 13:36
Seems more like a CLEANUP task thoughDataHandler.php:8098If the $pageIds gets very large the in clause could crash with an SQL error -
Jigal van Hemert commented on patch set 1 CR +1 V +1 02/01/17, 19:21
DataHandler.php:8098ReplySure, but that was also the case before this patch. -
Georg Ringer commented on patch set 1 02/01/17, 19:43
GeneralUtility.php:1212please don't mix changes. this change has nothing to do with the initial cleanup. this makes it just harder to review. -
Stephan Großberndt commented on patch set 1 02/01/17, 22:46
In general I'm with you Georg, but I spotted that during research for that patch and it's really not worth a single patch itself. If you insist, I'll upload a new PS without that. Since it's only a comment typo I hope you are ok with it as it is.DataHandler.php:8098ReplyThere are lots of places in the core where that applies. that should be solved on a general basis and in a different patch. -
Thomas Hohn commented on patch set 1 02/02/17, 06:27
DataHandler.php:8098ReplyI agree - I would also rather get of the NOT in since they are more expensive - and turning an IN () into something else is not always a no brainer ;-) -
Thomas Hohn commented on patch set 1 V +1 02/07/17, 14:18
Testet -
Jigal van Hemert voted on patch set 1 CR +2 V +2 03/22/17, 21:30
-
Gerrit merged patch set 1 03/22/17, 21:30