Review main Merged

51501[BUGFIX] Render prepended option tag always in first place

Marcus Schwemer CR +2 V +2 Easy +18 −5 updated 05/18/17, 13:09

Commit message

Currently the prepend option is rendered together with the options
argument from select viewhelper. Using the option "optionsAfterContent"
renders also the prepend option after the children. The preprend
option is now rendered always in the first place.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jan Helke +1
  • Verified V +2
    • Christian Kuhn +2
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1013

  1. Marcus Schwemer uploaded patch set 1 02/01/17, 16:49

  2. Marcus Schwemer commented on patch set 1 02/01/17, 16:51

    I need to rebase the patch, when the conflicting one is merged.
  3. TYPO3com voted on patch set 1 V +1 02/01/17, 16:53 Completed build in 04m 52s on Wed, 1 Feb, 05:53 PM Test Summary: 55733 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7308

  4. Marcus Schwemer uploaded patch set 2 02/01/17, 20:34

  5. TYPO3com voted on patch set 2 V +1 02/01/17, 20:39 Completed build in 04m 31s on Wed, 1 Feb, 09:39 PM Test Summary: 55727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7313

  6. Jan Helke voted on patch set 2 CR +1 V +1 05/17/17, 16:25

  7. Tymoteusz Motylewski commented on patch set 2 05/17/17, 19:15

    shouldn't we backport this patch to other branches? if yes, please modify the Releases: line in the commit message
  8. Christian Kuhn updated the commit message in patch set 3 05/18/17, 13:00

  9. Jan Helke voted on patch set 3 CR +1 V +1 05/18/17, 13:01

  10. TYPO3com voted on patch set 3 V +1 05/18/17, 13:06 Completed build in 05m 21s on Thu, 18 May, 03:06 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11572

  11. Christian Kuhn voted on patch set 3 CR +2 V +2 05/18/17, 13:08

  12. Gerrit merged patch set 3 05/18/17, 13:08

  13. Christian Kuhn commented on patch set 4 05/18/17, 13:09

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 7e4e52407d20d53cf3feace9a38ff0f67af7458d