Review main Merged

51504[BUGFIX] Set TYPO3_DLOG constant in testing framework

Markus Klein CR +2 V +2 Easy +3 −0 updated 02/02/17, 12:36

Commit message

The constant is undefined currently and hence leads to useless calls
to the devLog facility.
Set this constant to false by default to avoid that.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Susi Moog +1
  • Verified V +2
    • Andreas Kienast +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Markus Klein uploaded patch set 1 02/02/17, 00:18

  2. TYPO3com voted on patch set 1 V +1 02/02/17, 00:24 Completed build in 05m 56s on Thu, 2 Feb, 01:24 AM Test Summary: 55727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7317

  3. Georg Ringer voted on patch set 1 CR +1 02/02/17, 03:36

  4. Andreas Kienast voted on patch set 1 CR +1 02/02/17, 08:36

  5. Susi Moog commented on patch set 1 CR -1 02/02/17, 08:37

    I'm on it.

    Testbase.php:133

    I'll move it in another method because this one is clearly called "defineTypo3ModeBe" ...
  6. Susi Moog commented on patch set 1 02/02/17, 08:50

    - the constant is only undefined in unit tests, in functional and acceptance tests it's already set by setUpBasicTypo3Bootstrap (defineLoggingAndExceptionConstants) - I'm not getting why we should need to set this generally for all unit tests (it's used nine times in the core in places where I'd say if you have a unit test touching these then you should take care of the constant there)
  7. Markus Klein uploaded patch set 2 02/02/17, 10:18

  8. TYPO3com voted on patch set 2 V +1 02/02/17, 10:24 Completed build in 05m 53s on Thu, 2 Feb, 11:24 AM Test Summary: 55727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7326

  9. Susi Moog commented on patch set 2 CR +1 V +1 02/02/17, 12:20

    I'm fine with this variant, perspectively we should remove that constant and use sensible logging
  10. Andreas Kienast voted on patch set 2 CR +2 V +2 02/02/17, 12:36

  11. Gerrit merged patch set 2 02/02/17, 12:36