Review main Merged

51518[FEATURE] Allow to set a custom id for fluid widgets

Marco Huber CR +2 V +2 Easy +40 −1 updated 02/07/17, 20:14

Commit message

With this patch you can set a customWidgetId parameter in the
widget viewhelper. This id is used in the widget identifier
in addition to the nextWidgetNumber.

With this patch two equal widgets in different content elements
don't influence each other.

A good value for the customWidgetId is the {contentObjectData.uid}.

Example:  <f:widget.paginate customWidgetId="{contentObjectData.uid}" ...

Review

  • Code review CR +2
    • Georg Ringer +2
    • Frans Saris +1
  • Verified V +2
    • Georg Ringer +2
    • Frans Saris +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1319

  1. Marco Huber uploaded patch set 1 02/03/17, 11:59

  2. TYPO3com voted on patch set 1 V -1 02/03/17, 12:04 Completed build in 04m 32s on Fri, 3 Feb, 01:04 PM Test Summary: 12 of 55901 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7393

  3. Marco Huber uploaded patch set 2 02/03/17, 12:30

  4. TYPO3com voted on patch set 2 V +1 02/03/17, 12:36 Completed build in 05m 59s on Fri, 3 Feb, 01:36 PM Test Summary: 55901 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7395

  5. Georg Ringer commented on patch set 2 CR -1 02/06/17, 04:53

    very nice. do it until today as tomorrow is feature freeze!
    that is certainly not a bugfix but a feature as it also introduces a new setting! please provide also a rst for the feature
    master only
  6. Marco Huber commented on patch set 2 02/06/17, 08:47

    Reply

    It's not documented anywhere that its not possible to use two pagebrowsers on one page. At least I haven't found something. So in my customers opinion its a bug... ;-) Where and how do I have to provide a rst?
  7. Georg Ringer commented on patch set 2 02/06/17, 08:50

    can be best written on https://forger.typo3.org/utility/rst and placed in EXT:core/Documentation/Changelog. Take a look at the other examples there as well
  8. Marco Huber uploaded patch set 3 02/06/17, 09:12

  9. TYPO3com voted on patch set 3 V +1 02/06/17, 09:18 Completed build in 05m 10s on Mon, 6 Feb, 10:18 AM Test Summary: 55955 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7549

  10. Georg Ringer updated the commit message in patch set 4 02/06/17, 09:53

  11. TYPO3com voted on patch set 4 V +1 02/06/17, 10:00 Completed build in 06m 36s on Mon, 6 Feb, 11:00 AM Test Summary: 55955 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7554

  12. Frans Saris voted on patch set 4 CR +1 02/07/17, 19:27

  13. Frans Saris voted on patch set 4 V +1 02/07/17, 19:31

  14. Frans Saris updated the commit message in patch set 5 02/07/17, 19:33

  15. Frans Saris voted on patch set 5 CR +1 V +1 02/07/17, 19:33

  16. TYPO3com voted on patch set 5 V -1 02/07/17, 19:39 Completed build in 06m 36s on Tue, 7 Feb, 08:39 PM Test Summary: 1 of 56147 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7727

  17. TYPO3com voted on patch set 5 V +1 02/07/17, 20:06 Completed build in 39m 52s on Tue, 7 Feb, 09:06 PM Test Summary: 56147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7727

  18. Georg Ringer voted on patch set 5 CR +2 V +2 02/07/17, 20:14

  19. Gerrit merged patch set 5 02/07/17, 20:14