51518[FEATURE] Allow to set a custom id for fluid widgets
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Frans Saris +1
-
Verified V +2
- Georg Ringer +2
- Frans Saris +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1319
-
Marco Huber uploaded patch set 1 02/03/17, 11:59
-
TYPO3com voted on patch set 1 V -1 02/03/17, 12:04 Completed build in 04m 32s on Fri, 3 Feb, 01:04 PM Test Summary: 12 of 55901 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7393
-
Marco Huber uploaded patch set 2 02/03/17, 12:30
-
TYPO3com voted on patch set 2 V +1 02/03/17, 12:36 Completed build in 05m 59s on Fri, 3 Feb, 01:36 PM Test Summary: 55901 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7395
-
Georg Ringer commented on patch set 2 CR -1 02/06/17, 04:53
very nice. do it until today as tomorrow is feature freeze!that is certainly not a bugfix but a feature as it also introduces a new setting! please provide also a rst for the featuremaster only -
Marco Huber commented on patch set 2 02/06/17, 08:47
Reply
It's not documented anywhere that its not possible to use two pagebrowsers on one page. At least I haven't found something. So in my customers opinion its a bug... ;-) Where and how do I have to provide a rst? -
Georg Ringer commented on patch set 2 02/06/17, 08:50
can be best written on https://forger.typo3.org/utility/rst and placed in EXT:core/Documentation/Changelog. Take a look at the other examples there as well -
Marco Huber uploaded patch set 3 02/06/17, 09:12
-
TYPO3com voted on patch set 3 V +1 02/06/17, 09:18 Completed build in 05m 10s on Mon, 6 Feb, 10:18 AM Test Summary: 55955 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7549
-
Georg Ringer updated the commit message in patch set 4 02/06/17, 09:53
-
TYPO3com voted on patch set 4 V +1 02/06/17, 10:00 Completed build in 06m 36s on Mon, 6 Feb, 11:00 AM Test Summary: 55955 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7554
-
Frans Saris voted on patch set 4 CR +1 02/07/17, 19:27
-
Frans Saris voted on patch set 4 V +1 02/07/17, 19:31
-
Frans Saris updated the commit message in patch set 5 02/07/17, 19:33
-
Frans Saris voted on patch set 5 CR +1 V +1 02/07/17, 19:33
-
TYPO3com voted on patch set 5 V -1 02/07/17, 19:39 Completed build in 06m 36s on Tue, 7 Feb, 08:39 PM Test Summary: 1 of 56147 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7727
-
TYPO3com voted on patch set 5 V +1 02/07/17, 20:06 Completed build in 39m 52s on Tue, 7 Feb, 09:06 PM Test Summary: 56147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7727
-
Georg Ringer voted on patch set 5 CR +2 V +2 02/07/17, 20:14
-
Gerrit merged patch set 5 02/07/17, 20:14