Review main Merged

51529[BUGFIX] Show warning label for linkhandler if no label is defined

Markus Klein CR +2 V +2 Easy +14 −1 updated 02/06/17, 19:50

Commit message

If the configuration for a linkhandler has an empty label
put a warning label there instead to give the integrator a hint
that the configuration is evaluated correctly.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1

Issues 1

Files 2

Review log 1011

  1. Markus Klein uploaded patch set 1 02/03/17, 21:25

  2. Andreas Kienast voted on patch set 1 CR +1 02/03/17, 21:30

  3. TYPO3com voted on patch set 1 V +1 02/03/17, 21:36 Completed build in 10m 40s on Fri, 3 Feb, 10:36 PM Test Summary: 55901 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7426

  4. Georg Ringer voted on patch set 1 CR +1 V +1 02/06/17, 04:54

  5. Thomas Hohn voted on patch set 1 CR +1 02/06/17, 05:47

  6. Nicole Hummel commented on patch set 1 CR -1 02/06/17, 17:55

    AbstractLinkBrowserController.php:245

    IMHO it should be !empty($configuration['label']) : $lang->sL($configuration['label']) ? $lang->sL(...)
  7. Nicole Hummel commented on patch set 1 CR 0 02/06/17, 18:22

    AbstractLinkBrowserController.php:245 Reply

    Okay, unfortunately sL() doens't return the input string for LLL: labels. Still you try to access an array key which might not exist
  8. Markus Klein uploaded patch set 2 02/06/17, 18:25

  9. Georg Ringer voted on patch set 2 CR +1 V +1 02/06/17, 19:37

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 02/06/17, 19:50

  11. Gerrit merged patch set 2 02/06/17, 19:50