Review TYPO3_7-6 Merged

51567[BUGFIX] Fix CGL script to new return status strategy of php-cs-fixer

Andreas Kienast CR +2 V +2 Easy +9 −2 updated 02/07/17, 21:03

Commit message

Status codes are only returned when running in dry-run mode.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Andreas Kienast commented on patch set 1 02/07/17, 20:55

    Cherry Picked from branch master.
  2. Christian Kuhn commented on patch set 1 CR -1 02/07/17, 20:56

    will push a couple of times here to verify bamboo.
  3. Christian Kuhn commented on patch set 1 CR +1 V +1 02/07/17, 20:59

    forget bamboo, the cgl fixer is not enabled for 7.6 build anyways. tested result of script run with dryrun argument locally, looks good.
  4. TYPO3com voted on patch set 1 V +1 02/07/17, 21:03 Completed build in 07m 30s on Tue, 7 Feb, 10:03 PM Test Summary: 38571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-701

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 02/07/17, 21:03

  6. Gerrit merged patch set 1 02/07/17, 21:03