Review main Merged

51581[BUGFIX] Exclude honeypot field in EXT:form from tabbing

Kevin Appelt CR +2 V +2 Easy +1 −1 updated 02/08/17, 14:39

Commit message

When tabbing trough a form in frontend the honeypot textfield was
reachable. Add a tabindex -1 which prevents the cursor to enter the
hidden field.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Daniel Goerz +1
    • Josef Glatz +1
    • Björn Jacob +1
    • Ralf Zimmermann +1
    • Andreas Kienast +1
    • Mathias Brodala +1
    • Philipp Gampe +1
  • Verified V +2
    • Wouter Wolters +2
    • Daniel Goerz +1
    • Josef Glatz +1
    • Björn Jacob +1
    • Ralf Zimmermann +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1518

  1. Kevin Appelt uploaded patch set 1 02/08/17, 13:10

  2. Mathias Brodala updated the commit message in patch set 2 02/08/17, 13:12

  3. Mathias Brodala voted on patch set 2 CR +1 02/08/17, 13:12

  4. Wouter Wolters updated the commit message in patch set 3 02/08/17, 13:15

  5. TYPO3com voted on patch set 1 V +1 02/08/17, 13:16 Completed build in 06m 28s on Wed, 8 Feb, 02:16 PM Test Summary: 56225 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7782

  6. Mathias Brodala voted on patch set 3 CR +1 02/08/17, 13:17

  7. TYPO3com voted on patch set 2 V +1 02/08/17, 13:18 Completed build in 06m 08s on Wed, 8 Feb, 02:18 PM Test Summary: 56225 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7783

  8. TYPO3com voted on patch set 3 V +1 02/08/17, 13:20 Completed build in 05m 37s on Wed, 8 Feb, 02:20 PM Test Summary: 56225 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7784

  9. Josef Glatz voted on patch set 3 CR +1 02/08/17, 13:21

  10. Ralf Zimmermann voted on patch set 3 CR -1 02/08/17, 13:29

  11. Ralf Zimmermann voted on patch set 3 CR +1 V +1 02/08/17, 13:31

  12. Philipp Gampe voted on patch set 3 CR +1 02/08/17, 13:33

  13. Josef Glatz voted on patch set 3 V +1 02/08/17, 13:34

  14. Andreas Kienast voted on patch set 3 CR +1 02/08/17, 13:35

  15. Daniel Goerz voted on patch set 3 CR +1 V +1 02/08/17, 13:58

  16. Björn Jacob voted on patch set 3 CR +1 V +1 02/08/17, 14:37

  17. Wouter Wolters voted on patch set 3 CR +2 V +2 02/08/17, 14:39

  18. Gerrit merged patch set 3 02/08/17, 14:39