Review main Merged

51585[BUGFIX] EXT:css_styled_content: always render all images

Christer V CR +2 V +2 Easy +1 −3 updated 02/12/17, 19:44

Commit message

In CssStyledContentController::render_textpic if $accessibilityMode
evaluates to false and $separateRows is also false, $allRows is never
added to $thisImages. This causes images to not be outputted
to the frontend.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Daniel Goerz +1
    • Benjamin Kott +1
  • Verified V +2
    • Georg Ringer +2
    • Benjamin Kott +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1317

  1. Christer V uploaded patch set 1 02/08/17, 14:30

  2. TYPO3com voted on patch set 1 V +1 02/08/17, 14:35 Completed build in 05m 05s on Wed, 8 Feb, 03:35 PM Test Summary: 56225 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7788

  3. Georg Ringer voted on patch set 1 CR +1 V +1 02/09/17, 04:05

  4. Thomas Hohn voted on patch set 1 CR +1 02/09/17, 05:02

  5. Andreas Kienast voted on patch set 1 CR +1 02/09/17, 08:26

  6. Benjamin Kott commented on patch set 1 CR -2 02/09/17, 09:31

    no rows should not be available anymore and was dropped in the refactoring - also there should be no case where the images are missing. will investigate
  7. Benjamin Kott uploaded patch set 2 02/09/17, 10:36

  8. Benjamin Kott voted on patch set 2 CR +1 V +1 02/09/17, 10:37

  9. TYPO3com voted on patch set 2 V +1 02/09/17, 10:41 Completed build in 04m 48s on Thu, 9 Feb, 11:41 AM Test Summary: 56231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7831

  10. Daniel Goerz updated the commit message in patch set 3 02/09/17, 10:42

  11. Daniel Goerz voted on patch set 3 CR +1 02/09/17, 10:42

  12. TYPO3com voted on patch set 3 V -1 02/09/17, 10:47 Completed build in 04m 40s on Thu, 9 Feb, 11:47 AM Test Summary: 1 of 56231 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7832

  13. Tymoteusz Motylewski commented on patch set 3 02/09/17, 11:01

    bamboo failure not related to the change
  14. TYPO3com voted on patch set 3 V +1 02/10/17, 08:03 Completed build in 21h 25m 25s on Fri, 10 Feb, 09:03 AM Test Summary: 56231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7832

  15. Benjamin Kott voted on patch set 3 CR +1 V +1 02/12/17, 17:12

  16. Georg Ringer voted on patch set 3 CR +2 V +2 02/12/17, 19:43

  17. Gerrit merged patch set 4 02/12/17, 19:44