Review main Merged

51586[BUGFIX] UpgradeAnalysis fails on symlinked core

Susi Moog CR +2 V +2 Easy +1 −1 updated 02/09/17, 01:58

Commit message

Class DocumentationFile compared a real path with
a symlinked path resulting in an exception, even
though both paths are the same.

Now realpath is called for both paths.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Daniel Goerz +1
    • Josef Glatz +1
    • Tobi Kretschmann +1
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Georg Ringer +2
    • Daniel Goerz +1
    • Josef Glatz +1
    • Tobi Kretschmann +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Susi Moog uploaded patch set 1 02/08/17, 14:37

  2. Tobi Kretschmann voted on patch set 1 CR +1 V +1 02/08/17, 14:39

  3. TYPO3com voted on patch set 1 V -1 02/08/17, 14:43 Completed build in 06m 00s on Wed, 8 Feb, 03:43 PM Test Summary: 18 of 56225 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7789

  4. Susi Moog uploaded patch set 2 02/08/17, 15:16

  5. TYPO3com voted on patch set 2 V +1 02/08/17, 15:21 Completed build in 04m 33s on Wed, 8 Feb, 04:21 PM Test Summary: 56225 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7793

  6. Tobi Kretschmann voted on patch set 2 CR +1 V +1 02/08/17, 15:21

  7. Wouter Wolters voted on patch set 2 CR +1 02/08/17, 15:36

  8. Andreas Kienast voted on patch set 2 CR +1 02/08/17, 16:45

  9. Daniel Goerz voted on patch set 2 CR +1 V +1 02/08/17, 18:45

  10. Josef Glatz commented on patch set 2 CR +1 V +1 02/08/17, 20:59

    Nice one, Thx
  11. Georg Ringer voted on patch set 2 CR +2 V +2 02/09/17, 01:58

  12. Gerrit merged patch set 2 02/09/17, 01:58