Review main Merged

51590[BUGFIX] FlexFormNoTabsContainer: Fix usage of array_pop()

Andreas Kienast CR +2 V +2 Easy +2 −1 updated 02/15/17, 12:21

Commit message

PHP’s `array_pop()` requires its argument being passed as reference,
but the result of `array_keys()` is directly used.
The result of `array_keys()` is now stored into a variable which gets
passed to `array_pop()`.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • Armin Vieweg +1
  • Verified V +2
    • Christian Kuhn +2
    • Mona Muzaffar +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1314

  1. Andreas Kienast uploaded patch set 1 02/08/17, 16:52

  2. Armin Vieweg voted on patch set 1 CR +1 02/08/17, 16:54

  3. TYPO3com voted on patch set 1 V +1 02/08/17, 16:57 Completed build in 05m 21s on Wed, 8 Feb, 05:57 PM Test Summary: 56225 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7794

  4. Georg Ringer voted on patch set 1 CR +1 02/09/17, 02:00

  5. Mona Muzaffar commented on patch set 1 02/09/17, 09:09

    Hey Andreas, could you tell me how i can reproduce the error?
  6. Andreas Kienast commented on patch set 1 02/09/17, 09:23

    I guess Armin can do that better, he made me aware of this issue. iirc you need to change the error reporting in TYPO3 to get noticed about E_NOTICE messages of PHP.
  7. Tymoteusz Motylewski commented on patch set 1 02/09/17, 10:21

    have found 3 other places with the same issue (but they can also be resolved in other issue): - typo3/sysext/core/Classes/Resource/AbstractFile.php line194 and line 274 - typo3/sysext/core/Classes/Resource/ResourceStorage.php line 1669
  8. Mona Muzaffar voted on patch set 1 V +1 02/09/17, 10:52

  9. Wouter Wolters voted on patch set 1 CR +1 02/14/17, 16:15

  10. Benni Mack voted on patch set 1 CR +2 02/15/17, 07:09

  11. Christian Kuhn commented on patch set 1 CR -1 02/15/17, 12:16

    will test
  12. Christian Kuhn voted on patch set 1 CR +2 V +2 02/15/17, 12:20

  13. Gerrit merged patch set 1 02/15/17, 12:20

  14. Christian Kuhn commented on patch set 2 02/15/17, 12:21

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit d375619fd588f11ce8bbf7fae06de3744d6c0432